Error saving a draft or published revision

Hi @lluisma thanks for reporting, I don't see any change related to your problem between 7.x-3.0rc2 and 7.x-3.0, are you sure the problem is not present in 7.x-3.0rc2?

Consider using the next time you report an issue the Issue Summary Template.

I'm having the same issue when saving a draft, including when setting it to needs review. It also seems to be deleting all old revisions regardless of the setting.

Notice: Undefined index: landing_page in node_revision_delete_workbench_moderation_transition() (line 300 of

Can you test if this patch solve the problem?

Thanks

Can you add more details like how to reproduce the issue and what error are you seeing?

I'm not using now D7 and I'm putting all my free time on the D8 version, so will be great if you can try to fix the issue and provide a patch.

I really don't know how the revisions works with the moderations states yet.

There is definitely something wrong here. After saving a new draft, it displays the same information as the published version, even though when editing the draft it shows the correct text.

That's how saving drafts has behaved, for the last couple years, at least... That's what it does for me too, just like the screenshot.

Does the Node Revisions error still occur? "Deleted X revisions. The website encountered an unexpected error. Please try again later."

If not, call this issue fixed.

@lluisma
That's the expected behavior since workbench moderation works with drafty module.
So when creating a draft, you will have a published revision automatically added on top as well.

I have this issue as well, and I will describe the reason for it.

If I configure the module to delete revisions older than 6 months, and I have a node with only two revisions older than 6 months for example, when saving the node with draft or published status, he will try to delete the two revisions, but the new revision is not yet in the database, especially in workbench_moderation_node_history table that contains the statuses of what is current and what is published, and as consequence he will try to delete a revision that is still current, causing the error.

Please have a look to the issue Updating nodes deletes revisions and using a wrong hook where I describe a full list of problems related to this hook and my proposal as well to fix it.

Thanks @nelsongrin

Was this actually fixed, or just split into different issues?

@solideogloria check #3134728: Updating nodes deletes revisions and using a wrong hook and #3134776: Current revision from workbench moderation is not excluded I will review soon this 2 issues.

Thanks @adriancid