Before

After

CommentFileSizeAuthor
#4 3117020-4.patch890 bytesjcnventura
#4 interdiff_2_4.txt892 bytesjcnventura
#2 3117020-2.patch667 bytesjibran
Screenshot from 2020-03-02 15-52-16.png8.77 KBjibran
Screenshot from 2020-03-02 15-52-01.png4.71 KBjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran at PreviousNext commented
Status: Active » Needs review
FileSize
3117020-2.patch667 bytes
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs review » Needs work

The patch sets it only to Third-party libraries instead of Third-party libraries are installed correctly

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs work » Needs review
FileSize
interdiff_2_4.txt892 bytes
3117020-4.patch890 bytes

This sets it to One Time Passwords (christian-riesen/otp) 2.1.0 or newer is installed if otp 2.1.0 is installed.

This package doesn't have the version number anywhere, and the only major change in the 2.x versions is the addition of checkHotpResync in version 2.1.0.

The module actually depends on that version as it uses this method, so the composer.json needs some adjustment. I'll create a different issue for that.

  • jcnventura authored 2893e27 on 8.x-1.x 
    Issue #3117020 by jibran, jcnventura: Fix the requirements appearance on...
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.