Pathauto requirements confusing message when running -dev

You should be able to move it, works for me?

But yes, it is in core, wouldn't help if it were in pathauto as the old version wouldn't have the check, which is the whole point here :)

The patch works for me very well.

It adds only check for if ($info['version']) {...}, which makes sense as Drupal does not have any version info about modules when using composer. I am not aware of any side effects this patch might have.

Note that #3123326: Remove pathauto version check from 9.0, no incompatible version is Drupal 9 compatible already removed this check for D9.

Not sure if we still want to bother with this in 8.9, but I suppose it doesn't hurt.

Thanks for the patch @penyaskito. 1 v small nit.

+++ b/core/modules/system/system.install
@@ -1098,14 +1098,16 @@ function system_requirements($phase) {
+      if ($info['version']) {
+        if (version_compare($info['version'], '8.x-1.5') <= 0) {
+          $requirements['pathauto_module_incompatibility'] = [
+            'title' => t('Pathauto'),
+            'description' => t('The Pathauto module is not compatible with the current version of Drupal core. Update the <a href=":url">Pathauto</a> module to 8.x-1.6 or later.', [
+              ':url' => 'https://drupal.org/project/pathauto',
+            ]),
+            'severity' => REQUIREMENT_ERROR,
+          ];
+        }

No need for the extra nesting...
if ($info['version] && version_compare($info['version'], '8.x-1.5') <= 0) {

Which makes this a 1- liner and easier to review too.

I somewhere there is an issue to use composer to get the installed version if not set which would also help in this instance. But out-of-scope here.

That is indeed nicer.

Discussed with @catch - we agreed this is good for 8.9.x since it could prevent you from updating in the event of a security release.

Committed 7b198e4 and pushed to 8.9.x. Thanks!