Add core_version_requirement: ^8 || ^9 to simplify.info.yml to designate that the module is compatible with Drupal 9

CommentFileSizeAuthor
#15 3117912-15.png23.1 KBManav
#13 d9-readiness-3117912-13.jpg69.43 KBHarishST
#13 interdiff_3-13.txt572 bytesHarishST
#13 d9-readiness-3117912-13.patch4.03 KBHarishST
#5 simplify-3117912-Screenshot_20200523_202627.png44.31 KBrorix
#3 3117912-3.patch4.03 KBdmitry.korhov
#2 drupal9-readiness-3117912-2.patch332 bytesmo_farhaz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
FileSize
drupal9-readiness-3117912-2.patch332 bytes

Updated core requirement version compatibility. please review it.

dmitry.korhov’s picture

dmitry.korhov
Primary language English
Location Poland, Warsaw
CreditAttribution: dmitry.korhov at EPAM Systems commented
FileSize
3117912-3.patch4.03 KB

Updated patch with deprecations of WebTestBase

nikolas.tatianenko’s picture

nikolas.tatianenko CreditAttribution: nikolas.tatianenko at EPAM Systems commented
Issue tags: +epam-contrib, +Drupal 9 porting weekend
rorix’s picture

rorix CreditAttribution: rorix commented
FileSize
simplify-3117912-Screenshot_20200523_202627.png44.31 KB

Tested the patch in #3 on dev on Drupal 8.9.0rc1.

1. Patch applied successfully.

modules / contrib / simplify / 3423e21 patch -p1 < 3117912-3.patch 
patching file simplify.info.yml
patching file src/Tests/GlobalSettingsTest.php
patching file src/Tests/PerBlockTypeSettingsTest.php
patching file src/Tests/PerCommentTypeSettingsTest.php
patching file src/Tests/PerContentTypeSettingsTest.php
patching file src/Tests/PerVocabularySettingsTest.php
patching file src/Tests/UserSettingsTest.php

2. Run upgrade-status.
simplify-3117912-Screenshot_20200523_202627.png
3. Checked a few options at /admin/config/user-interface/simplify and verified those get hidden as intended.

However i didn't run any UnitTests.

Status: Needs review » Needs work

The last submitted patch, 3: 3117912-3.patch, failed testing. View results

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Priority: Minor » Normal

Setting priority to normal as this module is currently unusable with Drupal 9 due to the version restrictions. Re-triggering test for D9 and D8.9

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Status: Needs work » Needs review
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Status: Needs review » Needs work

Patch failed again, seems to need a reroll?
Also see https://www.palantir.net/blog/jumpstart-your-drupal-9-upgrade-drupal-rector

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Issue tags: +ProjectUpdateBotD9, +Drupal 9 compatibility

Let's see what the Update bot says.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented
Issue tags: +DIACWJuly2020
HarishST’s picture

HarishST
he/him
Location Kerala
CreditAttribution: HarishST as a volunteer commented
Assigned: Unassigned » HarishST
Status: Needs work » Active
HarishST’s picture

HarishST
he/him
Location Kerala
CreditAttribution: HarishST as a volunteer and for Drupal India Association commented
Assigned: HarishST » Unassigned
Status: Active » Needs review
FileSize
d9-readiness-3117912-13.patch4.03 KB
interdiff_3-13.txt572 bytes
d9-readiness-3117912-13.jpg69.43 KB

When applied the patch from #3, upgrade status was shown some Warnings. Those are fixed with this patch. Upgrade status now shows no compatibility issues.
Interdiff is included.
Please review.

Manav’s picture

Manav CreditAttribution: Manav as a volunteer commented
Assigned: Unassigned » Manav
Manav’s picture

Manav CreditAttribution: Manav as a volunteer and for Drupal India Association commented
Assigned: Manav » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
3117912-15.png23.1 KB

#13 is working fine for me without any error.
Screen-shot attached for the same.

@HarishST: greate work thanks

RTBC

nord102’s picture

nord102
he/him
Primary language English
CreditAttribution: nord102 at Northern Commerce commented

Looks good, thanks for the patches all!

  • nord102 committed 849c400 on 8.x-1.x authored by HarishST 
    Issue #3117912 by HarishST, mo_farhaz, dmitry.korhov: Drupal 9 readiness
nord102’s picture

nord102
he/him
Primary language English
CreditAttribution: nord102 at Northern Commerce commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.