"core_version_requirement" property is missing in the info.yml file

CommentFileSizeAuthor
#12 3117984-12.patch492 bytesswentel
#7 3117984-7.patch358 bytesneelam_wadhwani
#7 interdiff_5-7.txt328 bytesneelam_wadhwani
#5 3117984-5.patch357 bytesneelam_wadhwani
#2 3117984-2.patch492 bytesneelam_wadhwani
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neelam_wadhwani created an issue. See original summary.

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117984-2.patch492 bytes

Kindly review patch.

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review
pefferen’s picture

pefferen CreditAttribution: pefferen as a volunteer commented

The patch in #2 would render the module incompatible with Drupal 8.8.*

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117984-5.patch357 bytes

Kindly review patch.
I updated the core version.

pefferen’s picture

pefferen CreditAttribution: pefferen as a volunteer commented

nice @neelam_wadhwani only you need to add 2 pipes for an logical OR:

core_version_requirement: ^8 || ^9

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
interdiff_5-7.txt328 bytes
3117984-7.patch358 bytes

Hello @pefferen
Thanks for it.
Kindly review update patch.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Reviewed & tested by the community » Needs review

Hmm this is tricky, I specifically opened a new branch for Drupal 9 to refactor code and remove stuff (although for the latter that's probably only those features that were already marked as deprecated in the UI like 'Region to block - which is already gone).

It means that in case someone still uses region to block in Drupal 8, it will break when upgrading to this branch - even so when upgrading to D9 of course.

@aspilicious: what do you think?

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work

You're correct.
I do see issues with the testbot that we need to add "core_version_requirement: ^9" to our test modules.

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented

Yep, looking at those today :)
Thanks for confirming !

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Needs work » Needs review
FileSize
3117984-12.patch492 bytes

Let's see if I can force the test to run.

  • swentel committed ab8f4a9 on 8.x-4.x 
    Issue #3117984 by neelam_wadhwani, swentel: "core_version_requirement"...
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Needs review » Fixed

Ok, branch is unblocked.

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Fixed » Closed (fixed)
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented

Opened a follow up at #3123064: Prepare 8.x-3.x for Drupal 8.8 and 9 - we can still make 8.x-3.x work for D9 and limit to 8.9 once that is released!