Ran drupal-check against e530697.

 ------ ----------------------------------------------------------------
  Line   editor_file.admin.inc
 ------ ----------------------------------------------------------------
  28     Call to deprecated function file_default_scheme():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal::config('system.file')->get('default_scheme') instead.
 ------ ----------------------------------------------------------------
CommentFileSizeAuthor
#6 3118338-6.patch905 bytesAnkush_03
#2 editor_file-3118338-1.patch531 bytesSteven Brown
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

FatGuyLaughing created an issue. See original summary.

Steven Brown’s picture

Steven Brown CreditAttribution: Steven Brown as a volunteer commented
FileSize
editor_file-3118338-1.patch531 bytes
John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Status: Active » Needs review
Issue tags: +Drupal 9 compatibility
John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Status: Needs review » Reviewed & tested by the community

I've checked the patch. It only changes the deprecated code.

Before patch:

$ drupal-check modules/contrib/editor_file/
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------- 
  Line   editor_file.admin.inc                               
 ------ ---------------------------------------------------- 
  28     Call to deprecated function file_default_scheme().  
 ------ ---------------------------------------------------- 

 [ERROR] Found 1 error

After patch:

vagrant@drupal8:/var/www/drupalvm/drupal/web$ ./vendor/bin/drupal-check modules/contrib/editor_file/
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [OK] No errors

Because there are no remaining deprecations, I've marking as RTBC.

douggreen’s picture

douggreen CreditAttribution: douggreen as a volunteer commented

We also need #3110068: Drupal 9 readiness

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 at Srijan | A Material+ Company for Srijan | A Material+ Company commented
FileSize
3118338-6.patch905 bytes

Add patch with both changes !

  • a60d897 committed on 8.x-1.x 
    Issue #3118338 by DuaelFr: remove all references to D8.
  • dd0eb55 committed on 8.x-1.x
    Issue #3118338 by FatGuyLaughing, ankushgautam76@gmail.com, John Cook,...
DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Status: Reviewed & tested by the community » Fixed

Commited.
Thank you all!

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 at Srijan | A Material+ Company for Drupal India Association commented
DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.