Problem/Motivation
As part of making this module ready for Drupal 9, we should add a missing core_version_requirement key to the module-info file also in missing composer.json file.

CommentFileSizeAuthor
#14 interdiff_12-14.txt386 bytesSuresh Prabhu Parkala
#14 3119603-14.patch2.82 KBSuresh Prabhu Parkala
#12 fixD9ReadlinesCompletely-3119603-11.patch2.34 KBedycarreyes99
#12 interdiff-3119603-2-11.txt2.34 KBedycarreyes99
#2 3119603.patch592 bytessamiksha.gupta008
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samiksha.gupta008 created an issue. See original summary.

samiksha.gupta008’s picture

samiksha.gupta008 CreditAttribution: samiksha.gupta008 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: samiksha.gupta008 » Unassigned
Status: Active » Needs review
FileSize
3119603.patch592 bytes
Stefdewa’s picture

Stefdewa CreditAttribution: Stefdewa at Calibrate commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3087361: Drupal 9 Deprecated Code report

Patch applies.

Also added related issue.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented

RTBC++

komalk’s picture

komalk CreditAttribution: komalk at Srijan | A Material+ Company for Drupal India Association commented
Issue tags: -Srijancontribution2020 +Drupal 9 compatibility, +Drupal 9 porting weekend, +DIACWMay2020
trebormc’s picture

trebormc
Primary language Catalan
Location Barcelona
CreditAttribution: trebormc as a volunteer and commented

RTBC++

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Capgemini commented

RTBC++

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Capgemini commented

Can we get this merged?

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

Shouldn't this include the \Drupal::l() => Link::fromTextAndUrl() conversion mentioned in #3087361: Drupal 9 Deprecated Code report?

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Capgemini commented

You can, but it's normally better to keep things separated no?

I suggest to first merge #3087361 so that all deprecations are gone, and then this one to make it fully D9 ready.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

As of yesterday, you can make changes to composer.json in a patch to make the project support drupal/core: ^8.0 || ^9.0 and run tests on the testbot. Wouldn't it make sense to make those changes and incorporate any fixes to make it support 9.0 at the same time?

edycarreyes99’s picture

edycarreyes99 CreditAttribution: edycarreyes99 at MTech, LLC commented
Assigned: Unassigned » edycarreyes99
Status: Reviewed & tested by the community » Needs review
FileSize
interdiff-3119603-2-11.txt2.34 KB
fixD9ReadlinesCompletely-3119603-11.patch2.34 KB

Fix D9 readlines completely

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Capgemini commented
Status: Needs review » Needs work

tests failed.

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs work » Needs review
FileSize
3119603-14.patch2.82 KB
interdiff_12-14.txt386 bytes

Please review!

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Reviewed & tested by the community

Tests are passing. LGTM.

Rar9’s picture

Rar9 CreditAttribution: Rar9 commented

getting error

composer require 'drupal/yoast_seo:1.x-dev'
Problem 1
- Conclusion: remove doctrine/annotations 1.10.3
- Conclusion: don't install doctrine/annotations 1.10.3

composer require 'drupal/yoast_seo:2.x-dev'
Problem 1
- Installation request for drupal/yoast_seo 2.x-dev -> satisfiable by drupal/yoast_seo[2.x-dev].
- Conclusion: remove drupal/core 9.0.2
- Conclusion: don't install drupal/core 9.0.2

cosolom’s picture

cosolom CreditAttribution: cosolom commented

@Rar9 It's because you need to apply this patch from git (not from the composer). I can confirm that patch is fine.

Rar9’s picture

Rar9 CreditAttribution: Rar9 commented

I just added patch 14 to composer.json

            "drupal/yoast_seo": {
                "fix d9 ": "https://www.drupal.org/files/issues/2020-07-13/3119603-14.patch"
            }

and the run composer require...

Why do i need to look for a patch somewhere at git?

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Priority: Normal » Critical

Please if you can spare time to commit this issue to the dev branch that will be nice.
A release after that will have a support for Drupal 9 build.
as this issue is a blocker issue for
#3122672: Start a 9.0.x branch for Varbase and Varbase Project to integrate with Drupal 9

Real physical testing with Drupal 9 is important as Drupal 9.0.5 went out

Thanks for having time to work on this nice and very useful module.

akalam’s picture

akalam CreditAttribution: akalam at Metadrop commented

I created a fork applying #14 in case someone need to use this project with D9 https://github.com/Metadrop/yoast_seo

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
CreditAttribution: phjou commented

It would be nice to merge that issue, it is pretty annoying to have to make a fork just to use the module.

Gomez_in_the_South’s picture

Gomez_in_the_South CreditAttribution: Gomez_in_the_South commented

+1 for getting this merged as it's RTBC.

Anything else that the maintainers are blocked by?

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
CreditAttribution: phjou commented

I guess the maintainers are not active anymore.

So I guess we have to wait for #3173941: Offering to co-maintain Real-time SEO for Drupal

Maybe people can ping on this issue to speedup the process #3169265: Offering to co-maintain Real-time SEO for Drupal

Kingdutch’s picture

Kingdutch
he/him
Primary language English
CreditAttribution: Kingdutch at Open Social commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Assigned: edycarreyes99 » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks for everyone's help on this issue, 2.0-alpha4 has been released.

This patch applied to 2.x (contrary to the issue's selected version) so work is still needed for 1.x. #3149492: Automated Drupal 9 compatibility fixes contains a start for 1.x

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
CreditAttribution: phjou commented

Thank you so much!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.