Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Running command
drupal-check -d modules/contrib/footnotes
generates following report :
5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ----------------------------------------------------------
Line footnotes.module
------ ----------------------------------------------------------
22 Call to deprecated method l() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Link instead.
Example:
------ ----------------------------------------------------------
------ ------------------------------------------------------------------------------
Line src/Plugin/Filter/FootnotesFilter.php
------ ------------------------------------------------------------------------------
54 \Drupal calls should be avoided in classes, use dependency injection instead
55 \Drupal calls should be avoided in classes, use dependency injection instead
187 \Drupal calls should be avoided in classes, use dependency injection instead
296 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------
[ERROR] Found 5 errors
Comments
Comment #2
panshulk CreditAttribution: panshulk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #3
Tolyan4ik CreditAttribution: Tolyan4ik at EPAM Systems commenteddrupal-check report:
6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
Comment #4
panshulk CreditAttribution: panshulk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedHey @Tolyan4ik
I am using the version "8.x-2.1" to check for deprecated code report.
Which version are you using to check the report.
I can still see the errors and deprecation messages.
Hence, moving this back to "Active".
Comment #5
panshulk CreditAttribution: panshulk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #7
pifagorHi @panshulk
You should check the dev version of the module.
I close it as fixed.
Comment #9
cestmoi CreditAttribution: cestmoi commented@pifagor, I updated to the dev module and tested with upgrade_status for D9 compatibility and got the following results:
Can anyone please confirm its compatibility with D9 ?
Thanks
Comment #10
pifagor@cestmoi
The dev version works with Drupal 9. However, the comments you mentioned should be corrected as well.