Add core_version_requirement: ^8 || ^9 to message_notify.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#4 3120194-4.patch1.34 KBheddn
#4 interdiff_2-4.txt1.03 KBheddn
#2 drupal9-readiness-3120194-2.patch326 bytesmo_farhaz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
FileSize
drupal9-readiness-3120194-2.patch326 bytes

Added core version requirement.
please review it

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs review » Reviewed & tested by the community

Thanks @mo_farhaz
Patch applied without error.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for American Federation of Teachers commented
Status: Reviewed & tested by the community » Needs review
FileSize
interdiff_2-4.txt1.03 KB
3120194-4.patch1.34 KB

Tested module w/ private message on 9.1.x. Notification emails are received by users. But to install a Drupal 9 site, I needed to update .info.yml files for the test and example modules as well. See updated patch.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented
Issue tags: +DIACWJuly2020
harika gujjula’s picture

harika gujjula CreditAttribution: harika gujjula at Specbee commented
Assigned: Unassigned » harika gujjula
harika gujjula’s picture

harika gujjula CreditAttribution: harika gujjula at Specbee for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community

@heddn Patch Applied successfully. But Since, Message notify has a dependency on Message module, which doesnot have the D9 compatibile version, it restricts from installing the module.
However, applied the available patch https://www.drupal.org/project/message/issues/3113123 for Message and then the module seems to work fine.

harika gujjula’s picture

harika gujjula CreditAttribution: harika gujjula at Specbee for Drupal India Association commented
Assigned: harika gujjula » Unassigned
hexblot’s picture

hexblot CreditAttribution: hexblot as a volunteer commented

Message core has had a D9 release for a couple of weeks now -- maybe push this change?
Seems to be working for us as well, would love to get rid of the (semi-)manual patching.

  • jhedstrom committed dae2c49 on 8.x-1.x authored by heddn 
    Issue #3120194 by heddn, mo_farhaz: Drupal 9 readiness
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.