Change System requirements URLs to new evergreen URLs

Thanks for the patch.

1) Searched the code for places drupal.org/requirements is used and found:

./core/install.php:  print 'Your PHP installation is too old. Drupal requires at least PHP 7.0.8. See the <a href="https://www.drupal.org/requirements">system requirements</a> page for more information.';
./core/INSTALL.txt:(https://www.drupal.org/requirements) in the Drupal.org online documentation.
./core/modules/aggregator/aggregator.install:    $requirements['curl']['description'] = t('The Aggregator module requires the <a href="https://secure.php.net/manual/en/curl.setup.php">PHP cURL library</a>. For more information, see the <a href="https://www.drupal.org/requirements/php/curl">online information on installing the PHP cURL extension</a>.');
./core/modules/system/system.install:      ':system_requirements' => 'https://www.drupal.org/requirements',
./core/modules/system/system.install:        ':link' => 'https://www.drupal.org/requirements/pdo',
./core/modules/system/system.install:          ':drupal-databases' => 'https://www.drupal.org/requirements/database',
./core/modules/system/system.install:          ':link' => 'https://www.drupal.org/requirements/pdo#pecl',
./core/modules/system/system.module:      return '<p>' . t("Here you can find a short overview of your site's parameters as well as any problems detected with your installation. It may be useful to copy and paste this information into support requests filed on Drupal.org's support forums and project issue queues. Before filing a support request, ensure that your web server meets the <a href=\":system-requirements\">system requirements.</a>", [':system-requirements' => 'https://www.drupal.org/requirements']) . '</p>';
./core/modules/simpletest/simpletest.install:    $requirements['curl']['description'] = t('The testing framework requires the <a href="https://secure.php.net/manual/en/curl.setup.php">PHP cURL library</a>. For more information, see the <a href="https://www.drupal.org/requirements/php/curl">online information on installing the PHP cURL extension</a>.');

a) https://www.drupal.org/requirements redirects to https://www.drupal.org/docs/8/system-requirements so doesn't need to be changed.

b) https://www.drupal.org/requirements/php/curl redirects to https://www.drupal.org/docs/7/system-requirements/php-requirements#curl and is handled by patch.

c) https://www.drupal.org/requirements/database redirects to https://www.drupal.org/docs/7/system-requirements/database-server and is not handled by patch.

d) https://www.drupal.org/requirements/pdo redirects to https://www.drupal.org/docs/7/system-requirements/what-is-pdo and is not handled by patch.

e) https://www.drupal.org/requirements/pdo#pecl redirects to https://www.drupal.org/docs/7/system-requirements/what-is-pdo#pecl and is not handled by patch.

2) Patch applies cleanly for 8.9 but needs reroll for D9.

[mac:kristen:drupal-8.9.x-dev]$ patch -p1 < 3120222-2.patch
patching file core/modules/aggregator/aggregator.install
patching file core/modules/simpletest/simpletest.install

[mac:kristen:drupal-9.0.x-dev]$ patch -p1 < 3120222-2.patch
patching file core/modules/aggregator/aggregator.install
patching file core/modules/simpletest/simpletest.install
Hunk #1 FAILED at 46.
1 out of 1 hunk FAILED -- saving rejects to file core/modules/simpletest/simpletest.install.rej

[mac:kristen:drupal-9.1.x-dev]$ patch -p1 < 3120222-2.patch
patching file core/modules/aggregator/aggregator.install
patching file core/modules/simpletest/simpletest.install
Hunk #1 FAILED at 46.
1 out of 1 hunk FAILED -- saving rejects to file core/modules/simpletest/simpletest.install.rej

3) Only aggregatorand simpletestare handled here but this could be updated to handle system.install too:

./core/modules/system/system.install:        ':link' => 'https://www.drupal.org/requirements/pdo',
./core/modules/system/system.install:          ':drupal-databases' => 'https://www.drupal.org/requirements/database',
./core/modules/system/system.install:          ':link' => 'https://www.drupal.org/requirements/pdo#pecl',

4) Marking back to "Needs work".

Found a more general issue. We can keep this open for now but it will likely be handled in #2855175: [META] Many documentation / handbook URLs redirect to D7 content.

Re-rolled patch from #2 for D9.1.x (ready to make changes suggested in #4, so leaving as NW).

#4.1c) Updated
#4.1d) There is no D8 equivalent page to https://www.drupal.org/docs/7/system-requirements/what-is-pdo, so replaced with a link to the section that mentions PDO
#4.1e) There is no D8 equivalent page to https://www.drupal.org/docs/7/system-requirements/what-is-pdo#pecl, so replaced with a link to the section that mentions PECL

Thanks for the update. Although the changes seem fine, I'm wondering if we should wait until the Drupal 9 redirects are in place because I found out recently the links are going to redirect to evergreen URLs:

#3133569: Migrate Drupal 8 & 9 documentation to evergreen format (instead of major version specific)

Now that the evergreen URLs are in place, these changes should happen:

Change:

https://www.drupal.org/docs/8/system-requirements/php-requirements#curl
to
https://www.drupal.org/docs/system-requirements/php-requirements#curl

Change (in 2 places):

https://www.drupal.org/docs/8/system-requirements/php-requirements#database
to
https://www.drupal.org/docs/system-requirements/php-requirements#database

Change:

https://www.drupal.org/docs/8/system-requirements/database-server
to
https://www.drupal.org/docs/system-requirements/database-server

Updated the URL with the correct ones. Please review!

Thanks for the update. The changes look fine and the patch applies cleanly. But, since we are fixing the URLs to go to evergreen URLs, it might be good to do that for the other Drupal 8 URLs in the install files at the same time. I see additional Drupal 8 URLs in system.install and jsonapi.install. Though now I'm wondering if there is another issue that's already fixing these. I'll do some searching.

I don't see anything specifically for changing all the Drupal 8 links to evergreen URLs (though I might have missed it). I do see this one:

#2855175: [META] Many documentation / handbook URLs redirect to D7 content

which is a generic issue of Drupal 7 links. I hate to close this one out in lieu of that one but maybe that is the correct approach. I'll ask around.

After discussing this with @mradcliffe, @catch, and @andrewmacpherson in the bugsmash Slack channel, it seems like this could be a child issue to the more general issue and that issue could be made into a meta issue.

Since this issue was focused on changing URLs like:

https://www.drupal.org/requirements*

I think it would make sense to have this issue focused on changing any "System requirements" URL rather than only the few already addressed in the patch. The following are the remaining files that have the "System requirements" URL (https://www.drupal.org/requirements) which can be changed to the new evergreen version (https://www.drupal.org/docs/system-requirements).

• /core/INSTALL.txt
• /core/module/system/system.install
• /core/module/system/system.module

Updating the remaining URLS.
Please review!

Sorry I wasn't clear. I was proposing to only change the system requirements URLs. In #13 I wrote:

"The following are the remaining files that have the "System requirements" URL (https://www.drupal.org/requirements) which can be changed to the new evergreen version (https://www.drupal.org/docs/system-requirements)."

If you think it should be handled differently, then the title and issue summary need to change to match the scope. Thanks.

I changed the PDO specific ones to the same general requirements url. Not sure if that was the intention but I didn't see a specific PDO docs page for D8.

Thanks for the update. I noticed a couple things:

1) Nitpick:

+++ b/core/INSTALL.txt
@@ -61,7 +61,7 @@ Drupal requires:
-(https://www.drupal.org/requirements) in the Drupal.org online documentation.
+(https://www.drupal.org/docs/system-requirements) in the Drupal.org online documentation.

Makes line go beyond 80 chars.

2) When searching for drupal.org/requirements after patching, there's still a URL here:

./core/modules/aggregator/aggregator.install:    $requirements['curl']['description'] = t('The Aggregator module requires the <a href="https://secure.php.net/manual/en/curl.setup.php">PHP cURL library</a>. For more information, see the <a href="https://www.drupal.org/requirements/php/curl">online information on installing the PHP cURL extension</a>.');

https://www.drupal.org/requirements/php/curl

Redirects to:

https://www.drupal.org/docs/7/system-requirements/php-requirements#curl

which is the Drupal 7 version. It should instead be:

https://www.drupal.org/docs/system-requirements/php-requirements#curl

Updating curl url in aggregator.install file and INSTALL.txt nitpick , kindly review.

Thanks for the update. Changes address #17.

I'm reading back through the old comments and it looks like some URLs were changed to the generic URL in #16 but I didn't catch that before because there was no interdiff. :(

IMO, these should be changed back:

1. +++ b/core/modules/system/system.install
   @@ -396,7 +396,7 @@ function system_requirements($phase) {
   -        ':link' => 'https://www.drupal.org/requirements/pdo',
   +        ':link' => 'https://www.drupal.org/docs/system-requirements',
   

   Use https://www.drupal.org/docs/system-requirements/php-requirements#database

2. +++ b/core/modules/system/system.install
   @@ -405,7 +405,7 @@ function system_requirements($phase) {
   -          ':drupal-databases' => 'https://www.drupal.org/requirements/database',
   +          ':drupal-databases' => 'https://www.drupal.org/docs/system-requirements',
   

   Use https://www.drupal.org/docs/system-requirements/database-server

3. +++ b/core/modules/system/system.install
   @@ -413,7 +413,7 @@ function system_requirements($phase) {
   -          ':link' => 'https://www.drupal.org/requirements/pdo#pecl',
   +          ':link' => 'https://www.drupal.org/docs/system-requirements',
   

   Use https://www.drupal.org/docs/system-requirements/php-requirements#database

Here I have addressed comment #19.

Changing status to needs review as #20 passed the tests.

Thanks for the update. Almost there!

1) Patch applies cleanly.

2) Tests pass.

3) Patch addresses issue in the issue summary.

4) Changes in #20 address items in #19.

5) After applying the patch and searching for any URLs like drupal.org/requirements*, there are none.

6) Checking each new URL shows that they work and they do not redirect anywhere else except for one. Sorry I didn't notice that before... or maybe it's a new redirect:

https://www.drupal.org/docs/system-requirements/database-server redirects to https://www.drupal.org/docs/system-requirements/database-server-requirem...

so that URL should be updated.

Moving back to needs work to address 6.

@Kristen Pol I have fixed the address 6 in #23, Please have a look.

Thanks for the update.

1) Patch applies cleanly and tests pass.

2) Interdiff looks good and addresses item from #23.6.

3) Checked that URL and it doesn't redirect to anything else.

4) I updated the issue summary to make the reasoning for this issue more clear.

Marking RTBC from this and #23.

Committed 23eaaf1 and pushed to 9.1.x. Thanks!