Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ --------------------------------------------------------------------------
Line src/Form/EditorImagePopupDialog.php
------ --------------------------------------------------------------------------
95 Call to deprecated function file_upload_max_size():
in Drupal 8.7.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Component\Utility\Environment::getUploadMaxSize() instead.
97 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------
[ERROR] Found 2 errors
Comment | File | Size | Author |
---|---|---|---|
#24 | Screenshot 2020-09-12 at 11.51.57 AM.png | 2.27 MB | JayKandari |
#20 | image-popup-upgrade-status2.png | 37.28 KB | Manav |
#20 | image-popup-upgrade-status1.png | 35.87 KB | Manav |
#18 | upgrade-status-export-2020-07-04T14_37_08+0530.txt | 194 bytes | BalajiDS |
#16 | Inkedimage-popup-upgrade-status.jpg | 1.66 MB | HarishST |
Comments
Comment #2
Sahana _N CreditAttribution: Sahana _N at Specbee commentedI have removed the deprecated code, please review the patch.
Comment #3
Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commentedHi @sahana,
In the above patch, I think there is a typo error in this line
$max_filesize = min(Bytes::toInt($image_upload['max_size']), Environment::getUploadMaxSiz());
Comment #4
Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commentedComment #5
Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commentedComment #6
Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commentedHi,
Please review this patch.
Comment #7
HarishSTChanging status to Needs Work. Since there are some issues found as below.
Patch available in the duplicate issue Drupal 9 readiness.
Need to add Core Version Requirement to make it compatible.
Comment #8
HarishSTThis patch fixes all the issues. Please review and verify! Thank you.
Comment #9
Kristen Pol@HarishST it's good to provide an interdiff when updating patches. https://www.drupal.org/documentation/git/interdiff
Comment #10
HarishSTSure @Kristen. Will add the interdiff along with the patch.
Comment #11
HarishSTI have added the interdiff along with the patch. @Kristen I have followed the procedure from the link you shared. Can you please verify the interdiff is fine and valid.
Comment #12
rakesh.gectcrNeeds work, upgrade status giving
Comment #13
rakesh.gectcrComment #14
rakesh.gectcrComment #15
rakesh.gectcrComment #16
HarishST@Rakesh I haven't found any issue on Upgrade Status after applying the patch. Am I missing something? I new in here, can you guide?
Also, Fixing Issue Tags.
Comment #17
vebrovski CreditAttribution: vebrovski at Agiledrop - Your Trusted Drupal Teammates commentedHi, I applied patch #11 and I don't see any issues in upgrade status or Rector.
Comment #18
BalajiDS CreditAttribution: BalajiDS at UniMity Solutions Pvt Limited for Drupal India Association commentedpatch #11 works fine.
Thanks,
@HarishST
Comment #19
HarishST@BalajiDS, please change the status to 'Reviewed & tested by community', if the patch works for you. Thank you!
Comment #20
Manav CreditAttribution: Manav as a volunteer and for Drupal India Association commented@HarishST: After appling the #11 patch. I didn't find issue.
Everything is wroking as exptected.
I have tested it with drupal_check and upgrade_status.
Attaching screen-shots.
Patch is working as expected.
RTBC
Comment #21
Manav CreditAttribution: Manav as a volunteer and for Drupal India Association commentedComment #22
JayKandariComment #24
JayKandariTested the patch #11 on a Drupal 9.1.x instance
Merged & Pushed to 2.x branch. Will create a new D9 compatible release shortly.
Thank you all for your contributions.
Comment #25
JayKandari