Fix PHP Coding Standards In Juicebox

CommentFileSizeAuthor
#28 interdiff_26-28.txt586 bytesnarendra.rajwar27
#28 3120896-28.patch51.02 KBnarendra.rajwar27
#26 interdiff_20-26.txt34.73 KBnarendra.rajwar27
#26 3120896-26.patch50.51 KBnarendra.rajwar27
#23 interdiff_16-20.txt1.33 KBnarendra.rajwar27
#21 interdiff_16-20.txt1.33 KBnarendra.rajwar27
#21 3120896-20.patch51.7 KBnarendra.rajwar27
#16 interdiff_14-16.txt544 bytesnarendra.rajwar27
#16 3120896-16.patch50.52 KBnarendra.rajwar27
#14 interdiff_10-14.txt864 bytesnarendra.rajwar27
#14 3120896-14.patch50.05 KBnarendra.rajwar27
#10 3120896-10.patch49.86 KBsnehalgaikwad
#7 interdiff_5-7.txt10.48 KBSuresh Prabhu Parkala
#7 3120896-7.patch138.89 KBSuresh Prabhu Parkala
#5 3120896-5.patch135.63 KBSuresh Prabhu Parkala
#2 3120896-2.patch104.68 KBkarishmaamin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

karishmaamin created an issue. See original summary.

karishmaamin’s picture

karishmaamin CreditAttribution: karishmaamin commented
Status: Needs work » Needs review
FileSize
3120896-2.patch104.68 KB

please review.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Needs work 
 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  104k  100  104k    0     0  45095      0  0:00:02  0:00:02 --:--:-- 45095
error: patch failed: src/Form/SettingsForm.php:41
error: src/Form/SettingsForm.php: patch does not apply
error: patch failed: src/Plugin/Field/FieldFormatter/JuiceboxFieldFormatter.php:127
error: src/Plugin/Field/FieldFormatter/JuiceboxFieldFormatter.php: patch does not apply
error: patch failed: src/Plugin/views/style/JuiceboxDisplayStyle.php:163
error: src/Plugin/views/style/JuiceboxDisplayStyle.php: patch does not apply
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Title: Short array syntax must be used to define array » Fix PHP Coding Standards
Issue summary: View changes
Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs work » Needs review
FileSize
3120896-5.patch135.63 KB

Re-rolled patch please review!

Status: Needs review » Needs work

The last submitted patch, 5: 3120896-5.patch, failed testing. View results

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs work » Needs review
FileSize
3120896-7.patch138.89 KB
interdiff_5-7.txt10.48 KB

Please review!

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
snehalgaikwad’s picture

snehalgaikwad CreditAttribution: snehalgaikwad at QED42 commented
Assigned: Unassigned » snehalgaikwad
snehalgaikwad’s picture

snehalgaikwad CreditAttribution: snehalgaikwad at QED42 commented
Assigned: snehalgaikwad » Unassigned
Status: Needs work » Needs review
FileSize
3120896-10.patch49.86 KB

Re-rolled patch.

Status: Needs review » Needs work

The last submitted patch, 10: 3120896-10.patch, failed testing. View results

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

Working on test case failure.

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Assigned: Unassigned » Suresh Prabhu Parkala
narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3120896-14.patch50.05 KB
interdiff_10-14.txt864 bytes

@Suresh Prabhu Parkala, I was looking into this issue as i have added comment. Adding patch. Lets have a look if it gets cleared the tests.

Status: Needs review » Needs work

The last submitted patch, 14: 3120896-14.patch, failed testing. View results

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3120896-16.patch50.52 KB
interdiff_14-16.txt544 bytes

Fixing Drupal\juicebox\JuiceboxFormatter::runCommonBuild() compatibility.

Status: Needs review » Needs work

The last submitted patch, 16: 3120896-16.patch, failed testing. View results

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented

@narendra.rajwar27 Sorry for that, I missed that comment, without refreshing the page I just updated. You are still working on it.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

@Suresh Prabhu Parkala, yes, i am working on it.

Thanks!

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Assigned: Suresh Prabhu Parkala » Unassigned
narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3120896-20.patch51.7 KB
interdiff_16-20.txt1.33 KB

Fixing compatibility in few more places.

Status: Needs review » Needs work

The last submitted patch, 21: 3120896-20.patch, failed testing. View results

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
interdiff_16-20.txt1.33 KB

Please ignore the interdiff file in #21 adding the correct interdiff for #21

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented

Needs a reroll again, sorry for this. Tests where failing so was actively committing it to dev.

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 52942  100 52942    0     0  24263      0  0:00:02  0:00:02 --:--:-- 24263
error: tests/src/FunctionalJavascript/JuiceboxCaseTestBase.php: No such file or directory
error: tests/src/FunctionalJavascript/JuiceboxConfCaseTest.php: No such file or directory
error: tests/src/FunctionalJavascript/JuiceboxConfGlobalCaseTest.php: No such file or directory
error: tests/src/FunctionalJavascript/JuiceboxFieldFormatterCaseTest.php: No such file or directory
error: tests/src/FunctionalJavascript/JuiceboxFileCaseTest.php: No such file or directory
error: tests/src/FunctionalJavascript/JuiceboxSubRequestCaseTest.php: No such file or directory
error: tests/src/FunctionalJavascript/JuiceboxViewsCaseTest.php: No such file or directory
narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

@Neslee Canil Pinto, thanks for the response. Working on it.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3120896-26.patch50.51 KB
interdiff_20-26.txt34.73 KB

Re-rolled patch using comment #21 patch.

Status: Needs review » Needs work

The last submitted patch, 26: 3120896-26.patch, failed testing. View results

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3120896-28.patch51.02 KB
interdiff_26-28.txt586 bytes

Updating patch for changing current_path_stack to currentPathStack

Status: Needs review » Needs work

The last submitted patch, 28: 3120896-28.patch, failed testing. View results

  • Neslee Canil Pinto committed 79a9518 on 8.x-2.x 
    Issue #3120896 by narendra.rajwar27, Suresh Prabhu Parkala, karishmaamin...
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs work » Fixed
Issue tags: -Needs reroll

Committed to dev and thanks. Will continue to work on tests now👍🏻

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.