CommentFileSizeAuthor
#10 d9-and-phpcs.patch4.79 KBAalokAtre
#2 3121595-2.patch1020 bytesSuresh Prabhu Parkala

Issue fork gdoc_field-3121595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Suresh Prabhu Parkala created an issue. See original summary.

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Active » Needs review
FileSize
3121595-2.patch1020 bytes

Please review!

Varun Rao’s picture

Varun Rao CreditAttribution: Varun Rao at Specbee commented
Status: Needs review » Reviewed & tested by the community

LGTM

riorick17 made their first commit to this issue’s fork.

riorick17 opened merge request !1

riorick17 closed merge request !1

devdesagar’s picture

devdesagar CreditAttribution: devdesagar at TATA Consultancy Services for Pfizer, Inc. commented

Hello Team,
We are using this module in our one drupal 9 project
Please release the stable version
Thanks and Regards,
Sagar Devde.

Rajeshreeputra made their first commit to this issue’s fork.

Rajeshreeputra opened merge request !2

AalokAtre’s picture

AalokAtre CreditAttribution: AalokAtre commented
FileSize
d9-and-phpcs.patch4.79 KB

Adding a patch that combines #2 and phpcs fixes.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
CreditAttribution: Webbeh at Georgia Institute of Technology commented

As a friendly reminder, we have four separate attempts at fixing it (#2, #5, #9, #10) where each of these are independent or not communicating how this differs from the work of the previous (except in #10, although I'd ask for an interdiff on that due to the discrepancy in size and perhaps scope outside of this issue).

  • AalokAtre authored d310101 on 8.x-1.x 
    Issue #3121595 by AalokAtre: Fixed drupal_set_message is deprecated
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle at Hannemyr Nye Medier AS commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

gisle credited deepanker_bhalla.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle at Hannemyr Nye Medier AS commented
Issue summary: View changes

Committed.

As for credits:

  1. #2: Fixes bug, credit to Suresh Prabhu Parkala
  2. #3: Provides review, credit to Varun Rao
  3. #4 & #5: Same as #2, no credit.
  4. #9: Same as #2, no credit.
  5. #10; Same as #2, but also fixes phpcs, credit to AalokAtre
  6. For #3001415: Coding standard, credit to deepanker_bhalla.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.