Problem/Motivation

Follow-up for #3098475: Add more strict checking of hook_update_last_removed() and better explanation

  1. +++ b/core/modules/system/tests/modules/update_test_last_removed/update_test_last_removed.install
    @@ -0,0 +1,20 @@
    + * Update functions for the update_test_invalid_hook module.
    

    Whoops. This is wrong here, and in the patch already committed to 9.0.x and 8.9.x.

  2. +++ b/core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathLastRemovedTest.php
    @@ -0,0 +1,72 @@
    + * Modules can define their last removed update function.
    

    True statement. ;) Is that what we want this class comment to say?

  3. setUp() is missing the {@inheritdoc}

Proposed resolution

Fix those comments.

Remaining tasks

  1. Do eeet. See #2
  2. Reviews/refinements.
  3. RTBC.
  4. Commit to 9.1.x, cherry-pick to 9.0.x and 8.9.x branches.
  5. Wait for #3098475: Add more strict checking of hook_update_last_removed() and better explanation backport to land in 8.8.x branch.
  6. Cherry-pick fix to 8.8.x branch.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww created an issue. See original summary.

dww’s picture

Status: Active » Needs review
FileSize
1.43 KB

Can't test this on 8.8.x until #3098475 is backported there, but this should work on 8.9.x and 9.0.x.

dww’s picture

Issue summary: View changes

Also, found 1 more doc nit that's fixed in #2.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Straightforward docs fixes, all look good to me.

  • catch committed 1e23061 on 9.1.x
    Issue #3121827 by dww: Documentation follow-up fixes for...

  • catch committed 69e7946 on 9.0.x
    Issue #3121827 by dww: Documentation follow-up fixes for...

  • catch committed 0b63e95 on 8.9.x
    Issue #3121827 by dww: Documentation follow-up fixes for...
catch’s picture

Committed/pushed to 9.1.x/9.0.x/8.9.x, leaving RTBC against 8.8.x

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

  • alexpott committed 4835db3 on 8.8.x authored by catch
    Issue #3121827 by dww: Documentation follow-up fixes for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.