Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Follow-up for #3098475: Add more strict checking of hook_update_last_removed() and better explanation
-
+++ b/core/modules/system/tests/modules/update_test_last_removed/update_test_last_removed.install @@ -0,0 +1,20 @@ + * Update functions for the update_test_invalid_hook module.
Whoops. This is wrong here, and in the patch already committed to 9.0.x and 8.9.x.
-
+++ b/core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathLastRemovedTest.php @@ -0,0 +1,72 @@ + * Modules can define their last removed update function.
True statement. ;) Is that what we want this class comment to say?
-
setUp()
is missing the{@inheritdoc}
Proposed resolution
Fix those comments.
Remaining tasks
Do eeet.See #2- Reviews/refinements.
- RTBC.
- Commit to 9.1.x, cherry-pick to 9.0.x and 8.9.x branches.
- Wait for #3098475: Add more strict checking of hook_update_last_removed() and better explanation backport to land in 8.8.x branch.
- Cherry-pick fix to 8.8.x branch.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Comment | File | Size | Author |
---|---|---|---|
#2 | 3121827-2.patch | 1.43 KB | dww |
Comments
Comment #2
dwwCan't test this on 8.8.x until #3098475 is backported there, but this should work on 8.9.x and 9.0.x.
Comment #3
dwwAlso, found 1 more doc nit that's fixed in #2.
Comment #4
longwaveStraightforward docs fixes, all look good to me.
Comment #8
catchCommitted/pushed to 9.1.x/9.0.x/8.9.x, leaving RTBC against 8.8.x
Comment #9
alexpott