CommentFileSizeAuthor
#12 3122018-12.patch6.58 KBAvani.addweb
#11 screenshot 2020-03-25 15.42.51.png226.83 KByas
#11 screenshot 2020-03-25 15.42.31.png167.24 KByas
45eb31d0-85e0-4729-99da-f9f14f65e407.png425.92 KBAvani.addweb
#2 3122018-2.patch1.46 KBAvani.addweb
#3 bule-20200324a.png222.93 KByas
#3 dark-20200324a.png176.04 KByas
#3 dark-20200324b.png328.86 KByas
#5 screenshot 2020-03-25 1.04.09.png172.72 KByas
#5 screenshot 2020-03-25 0.56.38.png174.19 KByas
#5 screenshot 2020-03-25 0.57.15.png176.49 KByas
#5 screenshot 2020-03-25 0.59.05.png339.76 KByas
#6 3122018-6.patch2.34 KBAvani.addweb
#7 screenshot 2020-03-25 3.53.16.png2.42 MByas
#10 interdiff-3122018-10.patch1.76 KBAvani.addweb
#10 3122018-10.patch2.55 KBAvani.addweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Avani.addweb created an issue. See original summary.

Avani.addweb’s picture

Avani.addweb CreditAttribution: Avani.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3122018-2.patch1.46 KB

@yas, Please test the attached patch for select2 dropdown design.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Active » Needs work
FileSize
bule-20200324a.png222.93 KB
dark-20200324a.png176.04 KB
dark-20200324b.png328.86 KB

@avaniaddweb

Thank you for fixing the color. Please see my comment in the screenshot shown in below:

  1. Blue theme: Cloud Server Template - Select2 Javascript dropdown box for Image ID
    bule-20200324a.png
  2. Dark theme: Cloud Server Template - Select2 Javascript dropdown box for Image ID (This is a good example, hoping you to fix the dropdown box height, though)
    dark-20200324a.png
  3. Dark theme: Cloud Server Template - Select2 Javascript dropdown box for Instance Type
    dark-20200324b.png

Note that I just picked up the examples, so I hope you to apply the changes to the same places in the other themes.

Avani.addweb’s picture

Avani.addweb CreditAttribution: Avani.addweb at AddWeb Solution Pvt. Ltd. commented

@yas, for point 3 Dark theme: I have applied same background color for Select dropdwon Instance Type. But this is a simple select-option dropdown. it's not javascript selectbox. so may be it's shows different background-color. can you please check it in different browsers and let me know your views.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
screenshot 2020-03-25 1.04.09.png172.72 KB
screenshot 2020-03-25 0.56.38.png174.19 KB
screenshot 2020-03-25 0.57.15.png176.49 KB
screenshot 2020-03-25 0.59.05.png339.76 KB

@avaniaddweb

Please refer to the following screenshots. I had the same results amongst all browsers.

  1. macOS (Catalina) Chrome

    09.png

  2. macOS (Catalina) Firefox

    38.png

  3. macOS (Catalina) Safari

    15.png

  4. Windows 10 Chrome

    05.png

Note that AMI Image ID is displayed correctly.

Avani.addweb’s picture

Avani.addweb CreditAttribution: Avani.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3122018-6.patch2.34 KB

@yas, I made changes according to your comments. Please check the attached patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
screenshot 2020-03-25 3.53.16.png2.42 MB

@avaniaddweb

Thank you for the update, but the patch didn't make change anything. The dropdown list (actually that is "table") background color is still white.

I think we should change or override the background-color of table.select2-results in aws_cloud_instance_type.css to bring this change to somewhere around in your dark mode theme, or specify the background-color of .select2-dropdown?

I just tried to edit the background-color in on-demand viewer, then it looks changed.

16.png

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@avaniaddweb

Note that I assume that AMI Image ID dropdown list is something like a normal select box, however Instance Type dropdown list is NOT a normal one. You can see five columns in the dropdown list in Instance Type. Therefore, I believe that they are different; so we need to set up the color one by one.

Avani.addweb’s picture

Avani.addweb CreditAttribution: Avani.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs work » Needs review
FileSize
3122018-10.patch2.55 KB
interdiff-3122018-10.patch1.76 KB

@yas, Yes you are right it's not simple dropdown. first of all, I am not able to find this type of column dropdown. Well, finally I found this type of dropdown and accordion to that I made changes. Please find attached patch for this.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work
FileSize
screenshot 2020-03-25 15.42.31.png167.24 KB
screenshot 2020-03-25 15.42.51.png226.83 KB

@avaniaddweb

Thank you for the update. I tried to apply the patch but received the following error after merging 3122018-10.patch:

$ git apply -v /tmp/3122018-10.patch
Checking patch css/dark-theme.css...
Checking patch css/form.css...
error: while searching for:
.messages__wrapper .alert-warning p {
  margin-bottom: 0;
}

error: patch failed: css/form.css:46
error: css/form.css: patch does not apply
Checking patch css/oceanic-theme.css...
Checking patch css/storm-theme.css...

So could you please re-create the patch again?

Also, could you please make a font of the Select2 dropdown list one step smaller?

e.g.

  • Extra Large → Large
  • Large → Medium
  • Medium → Small
  • Small → Extra Small
  • Extra Small → Extra Small

Please compare the Select2 dropdown list font size and normal select box.

31.png

51.png

Avani.addweb’s picture

Avani.addweb CreditAttribution: Avani.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3122018-12.patch6.58 KB

@yas, Thanks for the review. I made the necessary changes according to that. Please check this one.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Reviewed & tested by the community

@avaniaddweb

Thank you for the update. It looks beautiful now. I'll merge the patch to 8.x-1.x and close this issue as Fixed.

  • yas committed 78ac42a on 8.x-1.x authored by Avani.addweb 
    Issue #3122018 by Avani.addweb, yas: Fix the color scheme in Select2...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.