CommentFileSizeAuthor
#2 3122834-2.patch383 bytesNeslee Canil Pinto
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neslee Canil Pinto created an issue. See original summary.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Active » Needs review
FileSize
3122834-2.patch383 bytes
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Evolving Web, Drupal Ukraine Community commented

Hello and thanks for the patch!
How about some deprecated code? Are we safe here?

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented

Hi Matroskeen,
There si no deprecated code in this module.

  • Matroskeen committed 7bc8112 on 8.x-1.x 
    Issue #3122834 by Neslee Canil Pinto, Matroskeen: Compatibility with...
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Drupal Ukraine Community commented
Status: Needs review » Fixed

We also had to apply the same to internal module 'Mailgun Email Templates Examples'.

Committed and pushed to 8.x-1.x.
Thanks!

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Fixed » Closed (fixed)
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Drupal Ukraine Community commented
Status: Closed (fixed) » Needs work

Re-opening because of https://www.drupal.org/pift-ci-job/1631107

  • Matroskeen committed 49d69e3 on 8.x-1.x 
    Issue #3122834 by Matroskeen: Compatibility with Drupal 9
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Drupal Ukraine Community commented
Status: Needs work » Postponed

Waiting for Mail System release with #3122405: Missing core_version_requirement key in test module included.

Failed tests: https://www.drupal.org/pift-ci-job/1631114

  • Matroskeen committed 9658721 on 8.x-1.x 
    Issue #3122834 by Matroskeen: Compatibility with Drupal 9
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Drupal Ukraine Community commented
Status: Postponed » Fixed

Finally, fixed: https://www.drupal.org/pift-ci-job/1641489
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.