Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Drupal-check reveals no issues, the module doesn't have a lot of code, and I've been making an effort to use non-deprecated methods, so I think it's good to go. I don't have any sites using commerce testing against 9.0 right now, so:
What is needed for RTBC?
Apply the patch, test with Commerce in Drupal 9. Do not mark this RTBC just because the patch applies cleanly.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3123947_9.patch | 471 bytes | nickolaj |
Comments
Comment #2
Balu ErtlMaybe you want to link this issue on the project page in the "Drupal 9 porting info" field?
Comment #3
John Pitcairn CreditAttribution: John Pitcairn commentedDone, thanks for the nudge.
Comment #4
Balu ErtlI think it can be shortened by just referencing the issue number itself:
Read more about this project’s readiness at \[\#3123947\](without the backslashes, of course)Comment #5
John Pitcairn CreditAttribution: John Pitcairn commentedHey you're right! For some reason I thought that only worked in issue queues. Thanks.
Comment #6
Balu ErtlComment #7
John Pitcairn CreditAttribution: John Pitcairn commentedAre you saying you've tested it against D9? If not, this issue should stay open.
I won't mark it fixed until we know it's good and the version compatibility in the .info.yml file is updated.
Comment #8
nickolajComment #9
nickolajComment #10
John Pitcairn CreditAttribution: John Pitcairn commentedThanks @nikolaj - yeah it's a trivial change, but have you actually tested it on a D9 commerce site?
Comment #11
nickolaj@John Pitcairn No, I did not.
Comment #12
John Pitcairn CreditAttribution: John Pitcairn commentedComment #14
John Pitcairn CreditAttribution: John Pitcairn commentedCommitted to dev to allow testing in composer-managed projects.
Comment #15
John Pitcairn CreditAttribution: John Pitcairn commentedWhen testing with Drupal 9, I'm seeing an extra "add to cart" button at the product level, outside and before the product variations rendered entity field. Huh. Investigating.Haha, forgot to disable "inject variation fields" for the product. I will add a note about that to the readme.Comment #16
John Pitcairn CreditAttribution: John Pitcairn commentedAll good, will tag a 1.2 release today.