Drupal 9 compatibility

Hi there,

I applied patch #2 and run the drupal-check and got the following issues.

drupal-check blocktabs/
24/24 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ----------------------------------------------------------------------
Line src/Form/BlocktabsAddForm.php
------ ----------------------------------------------------------------------
17 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Form/BlocktabsEditForm.php
------ ----------------------------------------------------------------------
222 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
245 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------------------
Line src/Form/BlocktabsFormBase.php
------ ----------------------------------------------------------------------------------
111 Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Entity\EntityInterface::toUrl() instead.
------ ----------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------
Line src/Form/TabDeleteForm.php
------ ----------------------------------------------------------------------------------
46 Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Entity\EntityInterface::toUrl() instead.
71 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
72 Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Entity\EntityInterface::toUrl() instead.
------ ----------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------
Line src/Form/TabFormBase.php
------ ----------------------------------------------------------------------------------
100 Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Entity\EntityInterface::toUrl() instead.
153 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
154 Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Entity\EntityInterface::toUrl() instead.
------ ----------------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line src/Plugin/Tab/BlockContentTab.php
------ -------------------------------------------------------------------------
54 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
------ -------------------------------------------------------------------------

------ -----------------------------------------------------------
Line src/Plugin/Tab/ViewsTab.php
------ -----------------------------------------------------------
111 Call to deprecated function drupal_render():
in drupal:8.0.0 and is removed from drupal:9.0.0. Use the
------ -----------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------------------------------
Line src/TabInterface.php
------ ---------------------------------------------------------------------------------------------------------------------------
20 Interface Drupal\blocktabs\TabInterface extends deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface:
Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated
in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement
ConfigurableInterface and/or DependentPluginInterface directly as needed. If
you implement ConfigurableInterface you may choose to implement
ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility,
however this must be removed prior to Drupal 9.
------ ---------------------------------------------------------------------------------------------------------------------------

[ERROR] Found 13 errors

I leave the changes by @mo_farhaz and fixed the issues mentioned above and create another patch.
Now the status of the deprecations is following

drupal-check blocktabs/
24/24 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

Please review and test.

Best regards,
Egor

Thanks for the patch. Patch applies cleanly and there are no errors for rector and drupal check.

Please update the core_version_requirement in info.yml as well.

modules/custom/blocktabs/blocktabs.info.yml Add core_version_requirement: ^8 || ^9 to modules/custom/blocktabs/blocktabs.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

Hi @akanksha-hp,

Thanks for the notice. Updated the patch.

Best regards,
Egor

I've checked #7.

Drupal-check, rector, upgrade-status report no issues.

Sanity-check on drupal 9.0.0-rc1 is passed.

So RTBCing.

committed.