Adding a patch to include VirtualLocation as an option for the Event @type tag default.

CommentFileSizeAuthor
#2 3124832-add-virtuallocation-event-type.patch551 bytesSamLerner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SamLerner created an issue. See original summary.

SamLerner’s picture

SamLerner CreditAttribution: SamLerner at CivicActions commented
FileSize
3124832-add-virtuallocation-event-type.patch551 bytes
SamLerner’s picture

SamLerner CreditAttribution: SamLerner at CivicActions commented
Title: Add VirtualLocation to options for Event @type » Add VirtualLocation to options for Event @type options
Phil Wolstenholme’s picture

Phil Wolstenholme CreditAttribution: Phil Wolstenholme at CTI Digital commented
Status: Active » Needs review

This looks good to me, the patch applied and I can see the new type 👍

  • KarenS committed f9d8b02 on 8.x-1.x authored by SamLerner 
    Issue #3124832 by SamLerner: Add VirtualLocation to options for Event @...
KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Active

Now need a patch for D7.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Active » Fixed

Setting this back to fixed for D8. The D7 change will be in #3138187: New event properties.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lussekatt’s picture

lussekatt CreditAttribution: lussekatt as a volunteer commented

I really appreciate that someone has implemented this and I've been able to apply the patch and use VirtualLocation. I'm having some trouble using it, however, when setting up my default metatag. I'm not sure it is an issue or just a lack of understanding on my part.

I work on a large website that only uses tokens to fill in its schema_metatags. I need to be able to use tokens on both VirtualLocation and Place so that regardless of what eventAttendanceMode is used, the correct location type (or types, in the case of MixedEventAttendanceMode) show in the metatag. Right now, using default metatags for Events I can only use VirtualLocation or a phyical location (Place/Administrative Area), but but not both in the default at the same time.

Is there a way to do this that I'm not thinking of, or is this an issue that should be worked on?

alok.tiwari’s picture

alok.tiwari CreditAttribution: alok.tiwari commented

HI @ lussekatt
Have you find any way to use tokens for location @type field so that we can dynamically assign it values?