Missing translations

Flag link Type options missing translations see screenshot You'll see the German translation currently available on l.d.o

Strings for all radio button descriptions are missing

Module Version : 8.x-4.0-beta1

Would be grate to get these four strings into a t(). By that we are able to translate 100 % flag ui

CommentFileSizeAuthor
#5 Captura de tela de 2020-05-04 15-24-56.png131.44 KBilgnerfagundes
#4 3127606-4.patch2.26 KBnace_fr
flag-missing-translations.jpg159.25 KBJoachim Namyslo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Joachim Namyslo created an issue. See original summary.

Joachim Namyslo’s picture

Joachim Namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
CreditAttribution: Joachim Namyslo commented
Issue summary: View changes
Joachim Namyslo’s picture

Joachim Namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
CreditAttribution: Joachim Namyslo commented
Title: Missing translations for Flag Modul Form Type » 4 translations for Flag module form type descriptions are missing
nace_fr’s picture

nace_fr CreditAttribution: nace_fr at Agiledrop - Your Trusted Drupal Teammates commented
Status: Active » Needs review
FileSize
3127606-4.patch2.26 KB

Hi. I have created a patch which should make those radio button descriptions translatable.

ilgnerfagundes’s picture

ilgnerfagundes CreditAttribution: ilgnerfagundes at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
Captura de tela de 2020-05-04 15-24-56.png131.44 KB

The patch applies well, I put the translation of one of the phrases and it worked.

TR’s picture

TR CreditAttribution: TR commented
Title: 4 translations for Flag module form type descriptions are missing » @ActionLinkType plugins do not have @Translatable descriptions
Version: 8.x-4.0-beta1 » 8.x-4.x-dev
Issue tags: -Missing UI Translations in 8.x-4.0-beta1 and below

+1 RTBC

This is definitely needed.

In the annotation for the @ActionLinkType plugins defined by Flag, the "description" should ALWAYS be marked @Translatable.

Patch in #4 fixes this, it still applies, and it still passes tests.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

  • Berdir committed c06dd13 on 8.x-4.x authored by nace_fric 
    Issue #3127606 by nace_fric, Joachim Namyslo, ilgnerfagundes, TR: @...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.