Cool module, thanks! 🎉

I see the entity is marked as translatable, but I'm not seeing any way to translate it from the UI. Am I missing something or is that just not implemented yet?

CommentFileSizeAuthor
#15 3128293-15.patch4.91 KBslv_
#13 3128293-13.patch1.56 KBdeviantintegral
#12 3128293-12.patch1.53 KBlarowlan
#8 3128293-8.patch589 byteslarowlan
#4 3128293.patch2.32 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

justafish created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Category: Support request » Bug report

Most likely a bug.
To be honest, translation is not my strong suite.
I thought I added the required annotations to make this work, but without a use-case, hadn't tested it.

Will try and carve out some time to dig into it.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Ah! it looks like content translation module only provides UI for entities that have a canonical route - which we don't.

So should just be a matter of adding them in.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Issue tags: +Needs tests
FileSize
3128293.patch2.32 KB

Give this a shot

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Note to self:\Drupal\Tests\node\Functional\NodeTranslationUITest should provide a good guide for an equivalent test for this

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
CreditAttribution: justafish as a volunteer commented

Thanks @larowlan! I applied the patch and enabled translation for Microcontent at /admin/config/regional/content-language, and now I get the option to translate the microcontent. However clicking it throws up this error

/admin/content/microcontent/1/translations

Drupal\Core\Entity\Exception\UndefinedLinkTemplateException: No link template 'canonical' found for the 'microcontent' entity type in Drupal\Core\Entity\EntityBase->toUrl() (line 227 of core/lib/Drupal/Core/Entity/EntityBase.php).
Drupal\content_translation\Controller\ContentTranslationController->overview(Object, 'microcontent') (Line: 17)
Drupal\tmgmt_content\Controller\ContentTranslationControllerOverride->overview(Object, 'microcontent')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 694)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

So content translation really wants the entity type to have a canonical URI.

Let me see what I can work out.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Active » Needs review
FileSize
3128293-8.patch589 bytes

It looks like block content just duplicates its edit form for the sake of a canonical route
Feels like a hack, but looks like tmgmt_content module can't handle the above patch so maybe shouldn't fight it.

Does this help?

deviantintegral’s picture

deviantintegral CreditAttribution: deviantintegral at Lullabot commented

Adding the canonical link looks to have fixed this for me - at least, I can now enable translations for a field.

deviantintegral’s picture

deviantintegral CreditAttribution: deviantintegral at Lullabot commented

Actually, this seems to break editing microcontent entities. Instead of rendering the edit form, the entity is rendered instead.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

ok, will wrangle that a bit later today

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
FileSize
3128293-12.patch1.53 KB

Perhaps this?

deviantintegral’s picture

deviantintegral CreditAttribution: deviantintegral at Lullabot commented
FileSize
3128293-13.patch1.56 KB

I was still getting exceptions when trying to load the canonical route. I think this is probably a core bug since returning FALSE / NULL matches the API, but instead I did what media module does.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Thanks, this looks good to me, just needs a test, will see if I can knock something out this week

slv_’s picture

slv_ CreditAttribution: slv_ at Lullabot for DocuSign commented
FileSize
3128293-15.patch4.91 KB

Re-rolling patch, adding KernelTest that verifies translation is handled by the default Core class, and that translations are stored as expected, with the proper per-translation values, etc.

  • larowlan committed b8b5c1c on 8.x-1.x authored by slv_ 
    Issue #3128293 by larowlan, deviantintegral, slv_, justafish:...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Fixed

Fixed, cutting 8.x-1.0-alpha8

Thanks all

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.