Tests are broken in 8.x-2.x-dev

This is the sort of change I had in mind. Note: I haven't tested it yet, but it shows the direction to take.

Does this work?

Just remove a deprecated asserts from JavascriptTestBase. See Disabled methods to inspect headers for JavascriptTestBase tests

-         $this->assertSession()->statusCodeEquals(200);

Per @mixologic:

So, the thing here is that the test is not running on the same filesystem as the headless chrome container.

So you cannot just “upload the file” because when you are “clicking the file upload” in chrome, its looking at its local filesystem for the file, not in the filesystem where you are running your test.

I know people have worked around this in the past by doing something that actually uploads the file to chromes’ filesystem first somehow. Im pretty sure there is a core test that does it even.

I wonder if the tests related to uploading files could be moved into functional tests that extend BrowserTestBase, and then leave the WebDriverTestBase tests to just test the output?

Ignore

@DamienMcKenna @Krzysztof Domański, wow we are getting near to it.

1) Drupal\Tests\juicebox\FunctionalJavascript\JuiceboxFileCaseTest::testFile
Behat\Mink\Exception\ExpectationException: The string "" was not found anywhere in the HTML response of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:768
/var/www/html/vendor/behat/mink/src/WebAssert.php:324
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:429
/var/www/html/core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php:315
/var/www/html/modules/contrib/juicebox/tests/src/FunctionalJavascript/JuiceboxFileCaseTest.php:66

Let's see what's displayed.

--- a/tests/src/FunctionalJavascript/JuiceboxFileCaseTest.php
+++ b/tests/src/FunctionalJavascript/JuiceboxFileCaseTest.php
@@ -60,6 +60,8 @@ class JuiceboxFileCaseTest extends JuiceboxCaseTestBase {
     $this->assertRaw(Html::escape(file_url_transform_relative($test_image_url)), 'Test image found in embed code');
     // Check for correct XML.
     $this->drupalGet($xml_path);
+    $content = $this->getRawContent();
+    var_dump($content);
     $this->assertRaw('<?xml version="1.0" encoding="UTF-8"?>', 'Valid XML detected.');

Unassigned. I will work on it yet. Maybe someone else will fix it in the meantime.

1) Drupal\Tests\juicebox\FunctionalJavascript\JuiceboxViewsCaseTest::testViews
Exception: invalid argument: File not found : /var/www/html/sites/simpletest/85280412/files/image-test.png
  (Session info: headless chrome=74.0.3729.157)
  (Driver info: chromedriver=2.38.552522 (437e6fbedfa8762dec75e2c5b3ddb86763dc9dcb),platform=Linux 4.9.0-0.bpo.6-amd64 x86_64)

+      $uri = \Drupal\file\Entity\File::load($this->node->{$this->instFieldName}[0]->target_id)->getFileUri();
+      var_dump($uri);

This problem has been fixed in #30. File exists "public://2020-07/image-test.png".

but we have other issues... See https://www.drupal.org/pift-ci-job/1767393

I think we can commit #30 because that blocks all tests. Let's create follow-up to fix other issues.

Ya i was thinking about commiting things, so we can get heads up for other tests that are failing

We need to install the Juicebox library.

See installation on Juicebox HTML5 Responsive Image Galleries.

Behat\Mink\Exception\UnsupportedDriverActionException: Status code is not available from Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver

See Disabled methods to inspect headers for JavascriptTestBase tests

For example, if a statusCodeEquals(200) was used, change it to assert the availability of an element on the page that you'd only expect on a successful page load.

"Status code is not available..." has been fixed, but there is still many issues...

1) Drupal\Tests\juicebox\FunctionalJavascript\JuiceboxConfCaseTest::testConfigLite
Behat\Mink\Exception\ExpectationException: The string "" was not found anywhere in the HTML response of the current page.

Let's see raw content.

+++ b/tests/src/FunctionalJavascript/JuiceboxConfCaseTest.php
@@ -51,7 +51,9 @@ class JuiceboxConfCaseTest extends JuiceboxCaseTestBase {
     $this->drupalGet('node/' . $node->id());
     $this->assertRaw(trim(json_encode(array('gallerywidth' => '100%', 'galleryheight' => '100%', 'backgroundcolor' => '#222222')), '{}'), 'Expected default configuration options found in Drupal.settings.');
     $this->drupalGet('juicebox/xml/field/node/' . $node->id() . '/' . $this->instFieldName . '/full');
-    $this->assertRaw('<juicebox gallerywidth="100%" galleryheight="100%" backgroundcolor="#222222" textcolor="rgba(255,255,255,1)" thumbframecolor="rgba(255,255,255,.5)" showopenbutton="TRUE" showexpandbutton="TRUE" showthumbsbutton="TRUE" usethumbdots="FALSE" usefullscreenexpand="FALSE">', 'Expected default configuration options set in XML.');
+    $content = $this->getSession()->getPage()->getContent();
+    var_dump($content);

Re #45

Testing Drupal\Tests\juicebox\FunctionalJavascript\JuiceboxConfCaseTest
Estring(232) "
404 Not Found

Let's split it into smaller tasks.

#3161405: Status code is not available from Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver

0k @Krzysztof Domański

@Krzysztof Domański should this be FunctionalJavascript test or just Functional tests?
May be we have to write only Functional test for this module

Hi @Krzysztof Domański, i fixed all the tests and committed to dev. Only 2 are remaining - https://www.drupal.org/pift-ci-job/1773556

Removed the unwanted functions.

Thanks @all for making this through.