Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MEENA BISHT created an issue. See original summary.

Gnanagowthaman sankar’s picture

Status: Active » Needs review
FileSize
424 bytes

Hi ,

Here is the patch.

meena.bisht’s picture

FileSize
429 bytes

Steps:

* Ensure that module codebase has no deprecations with the latest Drupal9 codebases.
* Added core version requirement and test that module is working fine after installation in Drupal8.
* Checked that module is working fine in drupal9 also.

I was working on this patch and was assigned to me as well, so I am adding my comment and patch here.

abhisekmazumdar’s picture

Status: Needs review » Reviewed & tested by the community

The looks good and the module works on D9 core too.
Thanks for the patch @MEENA BISHT & @Gnanagowthaman sankar

@Gnanagowthaman sankar
"Kindly before picking up any issue check if someone already is working on it, It will help in saving the duplication of efforts."

Thank You

abhisekmazumdar’s picture

Assigned: meena.bisht » Unassigned
dipakmdhrm’s picture

Status: Reviewed & tested by the community » Needs work

Please change from core_version_requirement: ^8.8.0 || ^9.0 to core_version_requirement: ^8 || ^9

meena.bisht’s picture

Assigned: Unassigned » meena.bisht
meena.bisht’s picture

Assigned: meena.bisht » Unassigned
pavnish’s picture

Assigned: Unassigned » pavnish

pavnish’s picture

Assigned: pavnish » Unassigned
dipakmdhrm’s picture

Status: Needs work » Fixed

Used the patch in #2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.