CommentFileSizeAuthor
#9 interdiff_2-9.txt1.86 KBnikitagupta
#9 3131242-9.patch4.46 KBnikitagupta
#5 interdiff_2-4.txt664 bytesnikitagupta
#5 3131242-4.patch5.16 KBnikitagupta
#2 3131242-2.patch6.81 KBankithashetty
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ankithashetty created an issue. See original summary.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
CreditAttribution: ankithashetty as a volunteer and at Specbee commented
Status: Active » Needs review
FileSize
3131242-2.patch6.81 KB

Replaced t() calls with $this->t() in the following patch, please review.

Thank you.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs review » Needs work 
+++ b/modules/rh_node/src/Tests/BehaviorSettingsFormAlterationsTest.php
@@ -83,7 +87,7 @@ class BehaviorSettingsFormAlterationsTest extends WebTestBase {
     $this->drupalPostForm(NULL, [
       'rh_override' => $override,
       'rh_action' => $action,
-    ], t('Save content type'));
+    ], $this->t('Save content type'));
 
     $saved_config = $this->behaviorSettingsManager->loadBehaviorSettingsAsConfig(
       'node_type', $test_content_type_id, TRUE);
@@ -141,7 +145,7 @@ class BehaviorSettingsFormAlterationsTest extends WebTestBase {

@@ -141,7 +145,7 @@ class BehaviorSettingsFormAlterationsTest extends WebTestBase {
     $this->drupalPostForm(NULL, [
       'rh_override' => $override,
       'rh_action' => $action,
-    ], t('Save content type'));
+    ], $this->t('Save content type'));
 
     $saved_config = $this->behaviorSettingsManager->loadBehaviorSettingsAsConfig(
       'node_type', $test_content_type_id, TRUE);
@@ -165,7 +169,7 @@ class BehaviorSettingsFormAlterationsTest extends WebTestBase {

@@ -165,7 +169,7 @@ class BehaviorSettingsFormAlterationsTest extends WebTestBase {
     $this->loadNodeFormForTestNode($node_id);
     $this->drupalPostForm(NULL, [
       'rh_action' => $action,
-    ], t('Save'));
+    ], $this->t('Save'));

t() calls are unnecessary in test cases.

See #3133726: [meta] Remove usage of t() in tests not testing translation

nikitagupta’s picture

nikitagupta CreditAttribution: nikitagupta at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » nikitagupta
nikitagupta’s picture

nikitagupta CreditAttribution: nikitagupta at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3131242-4.patch5.16 KB
interdiff_2-4.txt664 bytes

@JeroenT made changes suggested by you. please review.

nikitagupta’s picture

nikitagupta CreditAttribution: nikitagupta at Srijan | A Material+ Company for Drupal India Association commented
Assigned: nikitagupta » Unassigned
nikitagupta’s picture

nikitagupta CreditAttribution: nikitagupta at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs review » Needs work

$this is not available in procedural code. Changes in .module file should be reverted.

nikitagupta’s picture

nikitagupta CreditAttribution: nikitagupta at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3131242-9.patch4.46 KB
interdiff_2-9.txt1.86 KB

@JeroenT made changes suggested by you. please review.

  • Matroskeen committed 5f67673 on 8.x-1.x authored by nikitagupta 
    Issue #3131242 by nikitagupta, ankithashetty, JeroenT: t() calls should...
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.