Problem/Motivation
As part of making this module ready for Drupal 9, we should add a missing core_version_requirement key to the module-info file.
see https://www.drupal.org/node/3070687

CommentFileSizeAuthor
#7 2020-09-22_11-10=link_class.png36.3 KBpeterhebert
#2 3131618-2.patch343 byteskomalk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

komalkolekar created an issue. See original summary.

komalk’s picture

komalk CreditAttribution: komalk at Srijan | A Material+ Company for Drupal India Association commented
Status: Active » Needs review
FileSize
3131618-2.patch343 bytes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue tags: -Drupal 9 porting dayDrupal 9 readinessDrupal 9 compatibility +Drupal 9 porting day, +Drupal 9 compatibility
Lilit_Ghazaryan’s picture

Lilit_Ghazaryan CreditAttribution: Lilit_Ghazaryan at EPAM Systems commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested #2 patch on Drupal core 9.0.0-beta3

Lilit_Ghazaryan’s picture

Lilit_Ghazaryan CreditAttribution: Lilit_Ghazaryan at EPAM Systems commented
Issue tags: +Drupal 9 porting weekend
nikolas.tatianenko’s picture

nikolas.tatianenko CreditAttribution: nikolas.tatianenko at EPAM Systems commented
Issue tags: +epam-contrib
peterhebert’s picture

peterhebert CreditAttribution: peterhebert at Rex Rana commented
FileSize
2020-09-22_11-10=link_class.png36.3 KB

I have applied the patch in #2, but I am getting another warning when I scan the module using Upgrade Status:

in web/modules/contrib/link_class/tests/src/Functional/LinkClassWidgetTest.php
Reflection error: Drupal\Tests\PhpunitCompatibilityTrait not found

link class warning

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks. Let's fix test (if necessary) in follow up.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.