Really we should have fixed #3133436: Preprocess functions aren't defined in hook_theme first, but since the main module is already marked as Drupal 9 ready, we should also mark the test modules as Drupal 9 ready.

CommentFileSizeAuthor
#2 views_slideshow-3133605-2.patch531 bytesdouggreen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

douggreen created an issue. See original summary.

douggreen’s picture

douggreen CreditAttribution: douggreen as a volunteer commented
Title: Drupal 9 ready » Tests also need to be marked as Drupal 9 ready
Issue summary: View changes
Status: Needs work » Needs review
FileSize
views_slideshow-3133605-2.patch531 bytes
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Reviewed & tested by the community

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

douggreen’s picture

douggreen CreditAttribution: douggreen as a volunteer commented

Please create a new release that includes this. Without it, I need to run the dev version on my site that I'm about to launch; and I'd prefer to use a stable tag :)

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented

This has been went in 8.x-4.7 release 3 months ago

douggreen’s picture

douggreen CreditAttribution: douggreen as a volunteer commented

It did not. See https://git.drupalcode.org/project/views_slideshow/activity. The tag was cut and then the next commit (almost a month later) was this issue.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented

Oh ya, sorry. Its not been in the release