Add core_version_requirement: ^8 || ^9 to video_filter.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#2 3134320-2.patch328 bytesmo_farhaz

Issue fork video_filter-3134320

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
FileSize
3134320-2.patch328 bytes

core version requirement added

stevensunsunsun’s picture

stevensunsunsun CreditAttribution: stevensunsunsun commented

Hi,

I was just wondering if you were far away from Drupal 9 release or if you could recommend another option in the meantime?

Thank you!

wylbur’s picture

wylbur CreditAttribution: wylbur at Electric Citizen commented
Parent issue: » #2854752: Plan for Video Filter 8.x-1.0 release

Adding this to release plan.

GaëlG made their first commit to this issue’s fork.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe at Kosada commented
Status: Needs review » Reviewed & tested by the community

I added the PHP 7.3 + MySQL 5.6 testbot and it confirmed that the tests pass on the patch in #2.

On a fresh Drupal 9 project I was successfully able to composer require from the issue fork branch by doing

composer create-project drupal/recommended-project:9.2 video-filter-test
cd video-filter-test
// Modified composer.json to set canonical false on packages.drupal.org and add the issue fork repository
vim composer.json
composer require drupal/video_filter:dev-3134320-drupal-9-readiness                                                      
./composer.json has been updated
Running composer update drupal/video_filter
Loading composer repositories with package information
Updating dependencies                                 
Lock file operations: 1 install, 0 updates, 0 removals
  - Locking drupal/video_filter (dev-3134320-drupal-9-readiness 492c4c1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Syncing drupal/video_filter (dev-3134320-drupal-9-readiness 492c4c1) into cache
  - Installing drupal/video_filter (dev-3134320-drupal-9-readiness 492c4c1): Cloning 492c4c1414 from cache
AdamEvertsson’s picture

AdamEvertsson CreditAttribution: AdamEvertsson as a volunteer and commented

☝️ Does this mean the module could have a stable release?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Almost..

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

I removed the old "core" line, it's worthless at this point.

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.