Folders aren't included in count of "Amount of images per page" [#313456]

Currently, all of the folders in a directory will show regardless of what "Amount of images per page" is set to. So if I have a directory of 5 folders and 4 images, with a "Amount of images per page" value of 3, I would see 5 folders and 3 images on the first page, 5 folders and 1 image on the second page.

I suppose this was intentional, so that you have folder access to a deeper level in the hierarchy regardless of what page you are on, but would it be possible to implement a feature to control the amount of images AND folders on a page? I'd like to have 12 icons per page, regardless of whether it's a folder or image. I guess doing it this way, you'd also have to limit folders to showing on just the first page ....

Thoughts?

Thanks!

-nick

Comments

Comment #1

rapsli CreditAttribution: rapsli commented 25 September 2008 at 18:30

Hm. I guess this would indeed make more sense and be more logic. Are you going to write a patch? I'm gonna be off to vacation for the coming two weeks, so nothing is going to change there.

Comment #2

ncy CreditAttribution: ncy commented 25 September 2008 at 21:02

i'll look into it, but no promises. still juggling my schedule and i probably won't have anything clean enough for a release anytime soon.

i think the tough part will be redoing the code to do pagination manually as opposed to relying on pager_query().

any recommendations? also, looks like folder sorting isn't implemented yet? and toggling individual folder images?

Comment #3

rapsli CreditAttribution: rapsli commented 26 September 2008 at 05:38

First off: Folder sorting should be implemented in the latest version (at least dev version).

I guess you already know where the difficulties are. My 2 cents (if you not already know):

fast_gallery.module:
line 555 fast_gallery_page(). Callback function from the menu
line 566 we get the all the pics as hierarchie from a folder and save them in an array
line 576 and just theme them for output

fast_gallery.class.php
line 183 getPicsHierarchy(). gettting the pics
depending on what sorting type, use different sql -> these one are all the none folder picture
line 234 we fetch the folders using the sorting

lines 183 - 250 are your lines. Hope this helps.

Comment #4

ncy CreditAttribution: ncy commented 3 October 2008 at 22:50

i spent some time on getting this implemented. along the way, i made several other changes, addressing several of the other problems listed in the support queue.

i had to restructure the database and do some crazy SQL calls ... but in the end, it works (in my tests thus far).

i'll post my version up soon, along with some documentation noting all of the addressed issues.

my version of the code went through a big overhaul, so i'm not sure how you want to include the changes in the next release. too many changes to warrant just using a simple patch file.

thanx,

-nick