Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Remove deprecated code and update to standards.
Comment | File | Size | Author |
---|---|---|---|
#5 | 3138097-5.patch | 6.54 KB | sharma.amitt16 |
Comments
Comment #2
esolitosComment #4
sharma.amitt16 CreditAttribution: sharma.amitt16 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #5
sharma.amitt16 CreditAttribution: sharma.amitt16 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedDrupal 9 check.
~/Sites/drupal-9.0.0-beta2/modules/contrib(9.1.x*) » drupal-check bisnode
8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
Fixed coding standard issues. Patch added.
Kindly review the patch.
Comment #6
sharma.amitt16 CreditAttribution: sharma.amitt16 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #8
esolitosHello and thank you for your contribution, the patch merely updates some doc comments, but non the less.
Comment #9
sharma.amitt16 CreditAttribution: sharma.amitt16 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented@esolitos, thanks for the review and commit.
Would you please change the status of the issue. This is still is Needs Review.
Comment #10
esolitosComment #11
sharma.amitt16 CreditAttribution: sharma.amitt16 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented@esolitos, Is there anything pending in this issue?
If not then please change the status to Fixed.
Comment #12
esolitosUntil D9 is officially launched I'll keep this open.
Comment #13
sharma.amitt16 CreditAttribution: sharma.amitt16 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedOK, now got the motive to keep it open.
Comment #14
Kristen PolAdjusting tags presuming this is for Drupal 9 porting weekend since patch was updated during that time.
IMO I would also mark this fixed if there is nothing left to do. Unless you want to wait on creating the release first but that's not what the issue summary says. I would suggest either:
1) Marked this fixed and add Drupal 9 plan notes to the project page that links to this issue and explains that a release will be made later (this makes it easy for people to know what your intentions are)
or
2) Mark this postponed and update the issue summary to say that this should wait until a release is created and also update the project page per above
Comment #15
esolitos