Remove deprecated code and update to standards.

CommentFileSizeAuthor
#5 3138097-5.patch6.54 KBsharma.amitt16
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

esolitos created an issue. See original summary.

esolitos’s picture

Issue tags: +Drupal 9 compatibility

  • esolitos committed b64c8c4 on 8.x-1.x
    Issue #3138097: Drupal 9 support and coding standards
    
sharma.amitt16’s picture

Assigned: Unassigned » sharma.amitt16
sharma.amitt16’s picture

Status: Active » Needs review
Issue tags: +DIACWMay2020
FileSize
6.54 KB

Drupal 9 check.

~/Sites/drupal-9.0.0-beta2/modules/contrib(9.1.x*) » drupal-check bisnode
8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

Fixed coding standard issues. Patch added.

Kindly review the patch.

sharma.amitt16’s picture

Assigned: sharma.amitt16 » Unassigned

esolitos’s picture

Hello and thank you for your contribution, the patch merely updates some doc comments, but non the less.

sharma.amitt16’s picture

@esolitos, thanks for the review and commit.

Would you please change the status of the issue. This is still is Needs Review.

esolitos’s picture

Status: Needs review » Active
sharma.amitt16’s picture

@esolitos, Is there anything pending in this issue?

If not then please change the status to Fixed.

esolitos’s picture

Until D9 is officially launched I'll keep this open.

sharma.amitt16’s picture

OK, now got the motive to keep it open.

Kristen Pol’s picture

Adjusting tags presuming this is for Drupal 9 porting weekend since patch was updated during that time.

IMO I would also mark this fixed if there is nothing left to do. Unless you want to wait on creating the release first but that's not what the issue summary says. I would suggest either:

1) Marked this fixed and add Drupal 9 plan notes to the project page that links to this issue and explains that a release will be made later (this makes it easy for people to know what your intentions are)

or

2) Mark this postponed and update the issue summary to say that this should wait until a release is created and also update the project page per above

esolitos’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.