FILE: /project/app/modules/custom/entity_share_cron/entity_share_cron.install
-----------------------------------------------------------------------------
31 | VIOLATION | Avoid unused local variables such as '$channel_config'.

FILE: /project/app/modules/custom/entity_share_cron/src/EntityShareCronService.php
----------------------------------------------------------------------------------
101 | VIOLATION | Avoid assigning values to variables in if clauses and the like (line '112', column '11').
151 | VIOLATION | Avoid assigning values to variables in if clauses and the like (line '157', column '9').
185 | VIOLATION | The method filterDataToImport has a boolean flag argument $keep_existing, which is a certain sign of a Single Responsibility Principle violation.
188 | VIOLATION | Avoid unused local variables such as '$key'.

FILE: /project/app/modules/custom/entity_share_cron/src/Form/SettingsForm.php
-----------------------------------------------------------------------------
67 | VIOLATION | The method buildForm() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
67 | VIOLATION | The method buildForm() has 101 lines of code. Current threshold is set to 100. Avoid really long methods.
67 | VIOLATION | The method buildForm() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
67 | VIOLATION | The method buildForm() has 101 lines of code. Current threshold is set to 100. Avoid really long methods.

Comments

Grimreaper created an issue. See original summary.

Grimreaper’s picture

Assigned: Grimreaper » Unassigned
Status: Active » Fixed

Not all violation had been fixed, but especially the ones with thresholds which can be subjective.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.