Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Ran drupal-check and found 37 issues:
drupal-check -ad .
27/27 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ -------------------------------------------------------------------------------------------------------------------------------
Line src/Annotation/FieldTypeExport.php
------ -------------------------------------------------------------------------------------------------------------------------------
83 Property Drupal\entity_export_csv\Annotation\FieldTypeExport::$exclusive (array) does not accept default value of type false.
------ -------------------------------------------------------------------------------------------------------------------------------
------ -------------------------------------------------------
Line src/Controller/EntityExportCsvDownload.php
------ -------------------------------------------------------
38 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------
Line src/EntityExportCsvBatch.php
------ -----------------------------------------------------------------------------------------------------------------
49 PHPDoc tag @param has invalid value ($bundle
The entity bundle type.): Unexpected token "$bundle", expected type at offset 117
49 PHPDoc tag @param has invalid value ($entity_type_id
The entity type on which to export.): Unexpected token "$entity_type_id", expected type at offset 46
204 PHPDoc tag @param has invalid value ($operations
An array of batch operations that were performed.): Unexpected token "$operations", expected type at offset 231
204 PHPDoc tag @param has invalid value ($results
An array of results for the given batch process.): Unexpected token "$results", expected type at offset 154
204 PHPDoc tag @param has invalid value ($success
A boolean if the batch process was successful.): Unexpected token "$success", expected type at offset 79
239 PHPDoc tag @param has invalid value ($bundle
The entity bundle type.): Unexpected token "$bundle", expected type at offset 122
239 PHPDoc tag @param has invalid value ($entity_type_id
The entity type on which to export.): Unexpected token "$entity_type_id", expected type at offset 51
------ -----------------------------------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------
Line src/EntityExportCsvManager.php
------ -------------------------------------------------------------------------------------------------------------------------------------
163 Property Drupal\entity_export_csv\EntityExportCsvManager::$entityTypeManager (Drupal\Core\Entity\EntityTypeManager) does not accept
Drupal\Core\Entity\EntityTypeManagerInterface.
272 Method Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() invoked with 2 parameters, 1 required.
287 Method Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() invoked with 2 parameters, 1 required.
------ -------------------------------------------------------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line src/EntityExportCsvManagerInterface.php
------ --------------------------------------------------------------------------------------
81 PHPDoc tag @param has invalid value ($bundle
The bundle.): Unexpected token "$bundle", expected type at offset 141
81 PHPDoc tag @param has invalid value ($entity_type_id
The entity type id.): Unexpected token "$entity_type_id", expected type at offset 86
------ --------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------
Line src/Event/EntityExportCsvFieldsEvent.php
------ -----------------------------------------------------------------------------------------------------------------------------------
15 Class Drupal\entity_export_csv\Event\EntityExportCsvFieldsEvent extends deprecated class Symfony\Component\EventDispatcher\Event:
since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead
------ -----------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------
Line src/Form/EntityExportCsv.php
------ -----------------------------------------------------------------------------------------------------------
113 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
478 PHPDoc tag @param has invalid value ($property): Unexpected token "$property", expected type at offset 54
------ -----------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------
Line src/Form/EntityExportCsvSettings.php
------ -----------------------------------------------------------------------------------------------------------
64 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
269 PHPDoc tag @param has invalid value ($property): Unexpected token "$property", expected type at offset 54
------ -----------------------------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------------------------------
Line src/Plugin/FieldTypeExport/AddressExport.php
------ ----------------------------------------------------------------------------------------------------------------------
72 PHPDoc tag @param has invalid value ($array
The array to change.): Unexpected token "$array", expected type at offset 89
72 PHPDoc tag @param has invalid value ($find
The key of the element before we want mode before the $move.): Unexpected token "$find", expected type at offset 136
72 PHPDoc tag @param has invalid value ($move
The key of the element we want to move before $find.): Unexpected token "$move", expected type at offset 222
------ ----------------------------------------------------------------------------------------------------------------------
------ ------------------------------------------------------------------------------------
Line src/Plugin/FieldTypeExport/DateRangeExport.php
------ ------------------------------------------------------------------------------------
105 Access to an undefined property Drupal\Core\Field\FieldItemInterface::$start_date.
108 Access to an undefined property Drupal\Core\Field\FieldItemInterface::$end_date.
------ ------------------------------------------------------------------------------------
------ ------------------------------------------------------------------------------
Line src/Plugin/FieldTypeExport/DateTimeExport.php
------ ------------------------------------------------------------------------------
104 Access to an undefined property Drupal\Core\Field\FieldItemInterface::$date.
------ ------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/FieldTypeExportBase.php
------ ---------------------------------------------------------------------------------------------------------------------------------------
92 Property Drupal\entity_export_csv\Plugin\FieldTypeExportBase::$properties (array<Drupal\Core\TypedData\DataDefinitionInterface>) does
not accept default value of type null.
133 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
193 Method Drupal\entity_export_csv\Plugin\FieldTypeExportBase::getPropertyColumnSeparatorOptions() invoked with 1 parameter, 0 required.
366 Method Drupal\entity_export_csv\Plugin\FieldTypeExportBase::export() should return string but returns array<int, mixed>.
410 Call to function is_null() with array<Drupal\Core\TypedData\DataDefinitionInterface> will always evaluate to false.
538 PHPDoc tag @param has invalid value ($property_name
The property name.): Unexpected token "$property_name", expected type at offset 57
695 Method Drupal\entity_export_csv\Plugin\FieldTypeExportBase::import() should return string but return statement is missing.
------ ---------------------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------
Line src/Plugin/FieldTypeExportManager.php
------ ---------------------------------------------------------------------
86 Variable $definitions in isset() always exists and is not nullable.
------ ---------------------------------------------------------------------
------ ---------------------------------------------------------------------------
Line tests/src/Functional/LoadTest.php
------ ---------------------------------------------------------------------------
Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
6 Class PHPUnit\Framework\TestCase not found and could not be autoloaded.
13 Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
13 Class PHPUnit\Framework\TestCase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------
[ERROR] Found 37 errors
Comment | File | Size | Author |
---|---|---|---|
#15 | 3138811-15.patch | 7.63 KB | Pooja Ganjage |
#11 | 3138811-11.patch | 6.35 KB | Pooja Ganjage |
#7 | 3138811-7.patch | 12.87 KB | Pooja Ganjage |
Comments
Comment #2
pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commentedComment #3
codersukanta CreditAttribution: codersukanta at Srijan | A Material+ Company for Drupal India Association commentedComment #4
codersukanta CreditAttribution: codersukanta at Srijan | A Material+ Company for Drupal India Association commentedComment #5
ankitsingh0188Comment #6
ankitsingh0188Apologies, unable to spare time for this. Unassigning so others may take this forward.
Thanks
Comment #7
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
I am applying patch for this issue.
Kindly review this patch once.
Let me know for any correction.
Thanks.
Comment #8
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #9
flocondetoile$exclusive is not an array but a boolean. It's the var type which needs to be fixed.
Comment #10
flocondetoileComment #11
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
Attached updated patch.
Kindly review this patch once.
Thanks.
Comment #12
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #13
flocondetoileThanks for your work.
Your patch #11 seems wrong. As it fix previous patch in #7 and so can only applied on the source code once the patch #7 will be applied.
Comment #14
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedThanks for your review.
Comment #15
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
Attached updated patch.
Kindly review this patch once.
Let me know if there are any corrections.
Thanks.
Comment #16
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #17
flocondetoileCodebase has changed a lot.
Committing fix found by code sniffer. Credited Pooja Ganjage for the previous work
Comment #19
flocondetoileThere is may be yet remaining deprecations. Look at them in follow up eventually.