Ran drupal-check and found 37 issues:

drupal-check -ad .

 27/27 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Annotation/FieldTypeExport.php                                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  83     Property Drupal\entity_export_csv\Annotation\FieldTypeExport::$exclusive (array) does not accept default value of type false.  
 ------ ------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------- 
  Line   src/Controller/EntityExportCsvDownload.php             
 ------ ------------------------------------------------------- 
  38     Unsafe usage of new static().                          
         💡 Consider making the class or the constructor final.  
 ------ ------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------- 
  Line   src/EntityExportCsvBatch.php                                                                                     
 ------ ----------------------------------------------------------------------------------------------------------------- 
  49     PHPDoc tag @param has invalid value ($bundle                                                                     
         The entity bundle type.): Unexpected token "$bundle", expected type at offset 117                                
  49     PHPDoc tag @param has invalid value ($entity_type_id                                                             
         The entity type on which to export.): Unexpected token "$entity_type_id", expected type at offset 46             
  204    PHPDoc tag @param has invalid value ($operations                                                                 
         An array of batch operations that were performed.): Unexpected token "$operations", expected type at offset 231  
  204    PHPDoc tag @param has invalid value ($results                                                                    
         An array of results for the given batch process.): Unexpected token "$results", expected type at offset 154      
  204    PHPDoc tag @param has invalid value ($success                                                                    
         A boolean if the batch process was successful.): Unexpected token "$success", expected type at offset 79         
  239    PHPDoc tag @param has invalid value ($bundle                                                                     
         The entity bundle type.): Unexpected token "$bundle", expected type at offset 122                                
  239    PHPDoc tag @param has invalid value ($entity_type_id                                                             
         The entity type on which to export.): Unexpected token "$entity_type_id", expected type at offset 51             
 ------ ----------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/EntityExportCsvManager.php                                                                                                       
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  163    Property Drupal\entity_export_csv\EntityExportCsvManager::$entityTypeManager (Drupal\Core\Entity\EntityTypeManager) does not accept  
         Drupal\Core\Entity\EntityTypeManagerInterface.                                                                                       
  272    Method Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() invoked with 2 parameters, 1 required.                 
  287    Method Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() invoked with 2 parameters, 1 required.                 
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/EntityExportCsvManagerInterface.php                                               
 ------ -------------------------------------------------------------------------------------- 
  81     PHPDoc tag @param has invalid value ($bundle                                          
         The bundle.): Unexpected token "$bundle", expected type at offset 141                 
  81     PHPDoc tag @param has invalid value ($entity_type_id                                  
         The entity type id.): Unexpected token "$entity_type_id", expected type at offset 86  
 ------ -------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Event/EntityExportCsvFieldsEvent.php                                                                                           
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  15     Class Drupal\entity_export_csv\Event\EntityExportCsvFieldsEvent extends deprecated class Symfony\Component\EventDispatcher\Event:  
         since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead                                                           
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   src/Form/EntityExportCsv.php                                                                               
 ------ ----------------------------------------------------------------------------------------------------------- 
  113    Unsafe usage of new static().                                                                              
         💡 Consider making the class or the constructor final.                                                      
  478    PHPDoc tag @param has invalid value ($property): Unexpected token "$property", expected type at offset 54  
 ------ ----------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   src/Form/EntityExportCsvSettings.php                                                                       
 ------ ----------------------------------------------------------------------------------------------------------- 
  64     Unsafe usage of new static().                                                                              
         💡 Consider making the class or the constructor final.                                                      
  269    PHPDoc tag @param has invalid value ($property): Unexpected token "$property", expected type at offset 54  
 ------ ----------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/FieldTypeExport/AddressExport.php                                                                          
 ------ ---------------------------------------------------------------------------------------------------------------------- 
  72     PHPDoc tag @param has invalid value ($array                                                                           
         The array to change.): Unexpected token "$array", expected type at offset 89                                          
  72     PHPDoc tag @param has invalid value ($find                                                                            
         The key of the element before we want mode before the $move.): Unexpected token "$find", expected type at offset 136  
  72     PHPDoc tag @param has invalid value ($move                                                                            
         The key of the element we want to move before $find.): Unexpected token "$move", expected type at offset 222          
 ------ ---------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------ 
  Line   src/Plugin/FieldTypeExport/DateRangeExport.php                                      
 ------ ------------------------------------------------------------------------------------ 
  105    Access to an undefined property Drupal\Core\Field\FieldItemInterface::$start_date.  
  108    Access to an undefined property Drupal\Core\Field\FieldItemInterface::$end_date.    
 ------ ------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/FieldTypeExport/DateTimeExport.php                                 
 ------ ------------------------------------------------------------------------------ 
  104    Access to an undefined property Drupal\Core\Field\FieldItemInterface::$date.  
 ------ ------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/FieldTypeExportBase.php                                                                                                     
 ------ --------------------------------------------------------------------------------------------------------------------------------------- 
  92     Property Drupal\entity_export_csv\Plugin\FieldTypeExportBase::$properties (array<Drupal\Core\TypedData\DataDefinitionInterface>) does  
         not accept default value of type null.                                                                                                 
  133    Unsafe usage of new static().                                                                                                          
         💡 Consider making the class or the constructor final.                                                                                  
  193    Method Drupal\entity_export_csv\Plugin\FieldTypeExportBase::getPropertyColumnSeparatorOptions() invoked with 1 parameter, 0 required.  
  366    Method Drupal\entity_export_csv\Plugin\FieldTypeExportBase::export() should return string but returns array<int, mixed>.               
  410    Call to function is_null() with array<Drupal\Core\TypedData\DataDefinitionInterface> will always evaluate to false.                    
  538    PHPDoc tag @param has invalid value ($property_name                                                                                    
         The property name.): Unexpected token "$property_name", expected type at offset 57                                                     
  695    Method Drupal\entity_export_csv\Plugin\FieldTypeExportBase::import() should return string but return statement is missing.             
 ------ --------------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   src/Plugin/FieldTypeExportManager.php                                
 ------ --------------------------------------------------------------------- 
  86     Variable $definitions in isset() always exists and is not nullable.  
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   tests/src/Functional/LoadTest.php                                          
 ------ --------------------------------------------------------------------------- 
         Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.  
  6      Class PHPUnit\Framework\TestCase not found and could not be autoloaded.    
  13     Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.  
  13     Class PHPUnit\Framework\TestCase not found and could not be autoloaded.    
 ------ --------------------------------------------------------------------------- 

[ERROR] Found 37 errors
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gaurav_drupal created an issue. See original summary.

pavnish’s picture

codersukanta’s picture

Assigned: Unassigned » codersukanta
codersukanta’s picture

Assigned: codersukanta » Unassigned
ankitsingh0188’s picture

Assigned: Unassigned » ankitsingh0188
ankitsingh0188’s picture

Assigned: ankitsingh0188 » Unassigned

Apologies, unable to spare time for this. Unassigning so others may take this forward.

Thanks

Pooja Ganjage’s picture

FileSize
12.87 KB

Hi,

I am applying patch for this issue.

Kindly review this patch once.

Let me know for any correction.

Thanks.

Pooja Ganjage’s picture

Status: Needs work » Needs review
flocondetoile’s picture

$exclusive is not an array but a boolean. It's the var type which needs to be fixed.

flocondetoile’s picture

Status: Needs review » Needs work
Pooja Ganjage’s picture

FileSize
6.35 KB

Hi,

Attached updated patch.

Kindly review this patch once.

Thanks.

Pooja Ganjage’s picture

Status: Needs work » Needs review
flocondetoile’s picture

Status: Needs review » Needs work

Thanks for your work.
Your patch #11 seems wrong. As it fix previous patch in #7 and so can only applied on the source code once the patch #7 will be applied.

Pooja Ganjage’s picture

Thanks for your review.

Pooja Ganjage’s picture

FileSize
7.63 KB

Hi,

Attached updated patch.

Kindly review this patch once.

Let me know if there are any corrections.

Thanks.

Pooja Ganjage’s picture

Status: Needs work » Needs review
flocondetoile’s picture

Codebase has changed a lot.
Committing fix found by code sniffer. Credited Pooja Ganjage for the previous work

  • Pooja Ganjage authored f8d4d42 on 8.x-1.x
    Issue #3138811 by Pooja Ganjage, flocondetoile: Drupal 9 Deprecated Code...
flocondetoile’s picture

Status: Needs review » Fixed

There is may be yet remaining deprecations. Look at them in follow up eventually.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.