CommentFileSizeAuthor
#6 3139327-6.patch409 bytespavnish
#2 3139327-2.patch380 bytespavnish
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pavnish created an issue. See original summary.

pavnish’s picture

Assigned: pavnish » Unassigned
Status: Active » Needs review
FileSize
380 bytes

Hi can you please review this patch.

lawxen’s picture

Status: Needs review » Needs work

core: 8.x
Delete this line like what commerce did https://git.drupalcode.org/project/commerce/-/blob/8.x-2.x/commerce.info...

pavnish’s picture

@lawxen if we delete core: 8.x then we need to add core_version_requirement: ^8.8 || ^9 and this version of module does not work for < drupal 8.8

pavnish’s picture

Status: Needs work » Needs review
pavnish’s picture

FileSize
409 bytes

@lawxen Hi
i have change the patch as suggested by you in #3
If you are good with this then plz commit this patch.

lawxen’s picture

Status: Needs review » Reviewed & tested by the community

this version of module does not work for >drupal 8.8

@pavnish I confirm this module can be used on drupal8.9

If you are good with this then plz commit this patch.

@pavnish I don't have the permission, we can ping @skyred to commit this,
@skyred, This patch make this module can be installed by composer.

  • pavnish authored 291aa12 on 8.x-1.x
    Issue #3139327 by pavnish: Drupal 9 Readiness
    
lawxen’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.