Replace usages of AssertLegacyTrait::assertUrl, that is deprecated

Adding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions

Added patch with replacements

Fixed failed tests

Needs reroll again :(

1. $ git grep assertUrl\(
   core/modules/views_ui/tests/src/Functional/DefaultViewsTest.php:    // $this->assertUrl('admin/structure/views');
   core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php:  protected function assertUrl($path) {
   core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php:    @trigger_error('AssertLegacyTrait::assertUrl() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->addressEquals() instead. See https://www.drupal.org/node/3129738', E_USER_DEPRECATED);
   core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php:      @trigger_error('Calling AssertLegacyTrait::assertUrl() with more than one argument is deprecated in drupal:8.2.0 and the method is removed from drupal:10.0.0. Use $this->assertSession()->addressEquals() instead. See https://www.drupal.org/node/3129738', E_USER_DEPRECATED);
   core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php:   * @expectedDeprecation AssertLegacyTrait::assertUrl() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->addressEquals() instead. See https://www.drupal.org/node/3129738
   core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php:   * @expectedDeprecation Calling AssertLegacyTrait::assertUrl() with more than one argument is deprecated in drupal:8.2.0 and the method is removed from drupal:10.0.0. Use $this->assertSession()->addressEquals() instead. See https://www.drupal.org/node/3129738
   core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php:    $this->assertUrl('bingo', 'Redundant message.');
   core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php:    $this->assertUrl($expected_route_name, ['test_entity' => $this->entityId], $entity, TRUE, $url);
   core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php:    $this->assertUrl($expected_route_name, $expected_route_parameters, $entity, TRUE, $url);
   core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php:    $this->assertUrl($expected_route_name, [], $entity, FALSE, $url);
   core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php:    $this->assertUrl('entity.test_entity.add_form', $expected_route_parameters, $entity, FALSE, $url);
   core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php:    $this->assertUrl('<none>', [], $entity, TRUE, $url);
   core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php:  protected function assertUrl($expected_route_name, array $expected_route_parameters, $entity, $has_language, Url $url) {
   
   

   $ git grep assertUrl\( | grep -v EntityUrlTest | grep -v AssertLegacyTrait
   core/modules/views_ui/tests/src/Functional/DefaultViewsTest.php:    // $this->assertUrl('admin/structure/views');
   

   It's ok to keep the one usage in inline comment in DefaultViewsTest to me.

2. +++ b/core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php
   @@ -194,6 +194,7 @@ public function testAssertNoCacheTag() {
   +   * @expectedDeprecation AssertLegacyTrait::assertUrl() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->addressEquals() instead. See https://www.drupal.org/node/3129738
   
   +++ b/core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php
   @@ -138,7 +138,6 @@ public static function getSkippedDeprecations() {
   -      'AssertLegacyTrait::assertUrl() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->addressEquals() instead. See https://www.drupal.org/node/3129738',
   

   Tested and removed as expected

If no CS violations and the testing passes, it's RTBC to me. Cycling back later.

No CS violations and GREEN as expected. Thanks @mondrake!

#19.1 I think we should actually update that here - either by changing the commented code, changing and uncommenting it, or removing it if the assertion is really not needed. Or if not add a follow-up to deal with the commented assertions in that test.

Needs another re-roll..

Committed c09dc39 and pushed to 9.1.x. Thanks!

For some reason this is still in the rtbc queue so pressing save again...