Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
When having more than one group content menu available for creation on a group, the link to the menu form opens a page not found.
Steps :
- Create a group type.
- Create a group instance.
- Create multiple group content menu types.
- Install those group content menu types for the group type.
- Go to /group/1/menu/add.
- Click on one of the add links: /group/1/menu/add/group_content_menu%3Amenu_id.
- Page is not found.
Proposed resolution
Fix the routing for the add form link.
Or maybe, use the create-form route instead of add-form for the links at /group/1/menu/add.
Side notes
You can workaround the bug by going to the /group/{group_id}/content/create/group_content_menu%3A{menu_id} path.
Comment | File | Size | Author |
---|---|---|---|
#7 | 3143838-7.patch | 4.28 KB | edysmp |
| |||
#5 | interdiff-4-5.txt | 588 bytes | edysmp |
#5 | 3143838-5.patch | 4.32 KB | edysmp |
| |||
#4 | 3143838-4.patch | 4.36 KB | edysmp |
#4 | interdiff-2-4.txt | 2.17 KB | edysmp |
Comments
Comment #2
edysmpHere a test that proves this issue.
Comment #4
edysmpThis issue was introduced here https://www.drupal.org/project/group_content_menu/issues/3130387#comment-13591680
The
entity.group_content_menu.add_form
route was changed to receive aGroupContentMenuType
instance, but thecreateForm
callback parameters were not updated. If we update the parameter it will not match with the parent definition, so I am reverting to use {plugin_id} as the argument instead of {group_content_menu_type}. If for any reason we would want to use the entity parameter (group_content_menu_type) we will need to create a function wrapper that call createFrom.Comment #5
edysmpClean test.
Comment #6
heddnNeeds re-roll after [#3144201 landed.
Comment #7
edysmpHere we go!
Comment #9
heddnThanks so much for the tests that reproduce the issue.