• Backport from 8.x-2.x branch to 8.x-1.x
CommentFileSizeAuthor
#4 3144137-4.patch70.45 KByas
#2 3144137-2.patch75.37 KByas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

Status: Needs work » Needs review
FileSize
75.37 KB

@baldwinlouie

Trying to backport to sync from 8.x-2.x to 8.x-1.x. Could you please review the patch?

baldwinlouie’s picture

Status: Needs review » Needs work

@yas, This patch looks good. However, I think we can regenerate this patch after this checkin: https://www.drupal.org/project/cloud_orchestrator/issues/3143998.

For example, see the code below, that should be removed.

+++ b/README.md
@@ -1,26 +1,45 @@
+Known Issues
+============
+
+1. 01-31-2020 - [Issue 3110911](https://www.drupal.org/project/cloud/issues/3110911)
+   Do not enable aws_cloud if a `Add Kubernetes Cloud Service Provider`
+   is not completed.
+
+   When adding a Metrics Server enabled Kubernetes cluster, the metrics
+   importing operation can potentially take a long time to complete.
+   During this process,  there might be database corruption if the aws_cloud
+   module is enabled.

This can be removed after merging the patch at: https://www.drupal.org/project/cloud_orchestrator/issues/3143998

yas’s picture

Status: Needs work » Needs review
FileSize
70.45 KB

@baldwinloue

Thank you for your review. I regenerated the patch. Could you please review the patch again? Thanks

baldwinlouie’s picture

Status: Needs review » Reviewed & tested by the community

@yas, thank you for the patch. It looks good to me now.

yas’s picture

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-1.x and close this issue as Fixed.

  • yas authored 3ae8d1e on 8.x-1.x
    Issue #3144137 by yas, baldwinlouie: Backport from 8.x-2.x branch to 8.x...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.