If there are already Group entities of a Group type and the menu content is enabled for this Group Type, creating Menus for already available Group entities of this type creates two identical duplicate records in the group_content_field_data. Any subsequent groups created adds just a normal single entry in the group_content_field_data as expected. So the bug actually is only when menus are created for already existing group entities.

CommentFileSizeAuthor
#9 3144201-9.patch4.18 KBedysmp
#9 interdiff-7-9.txt1.43 KBedysmp
#7 interdiff-4-6.txt1.92 KBedysmp
#6 3144201-6.patch4 KBedysmp
#4 3144201-4.patch2.07 KBedysmp
Screen Shot 2020-05-31 at 6.53.06 PM.png75.76 KBDrupak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Drupak created an issue. See original summary.

Dakwamine’s picture

Dakwamine
Primary language French
CreditAttribution: Dakwamine as a volunteer and at emerya commented

Just wanted to add that I have also had those duplicate entries for some reason. They refer to the same menu.

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
CreditAttribution: edysmp at MTech, LLC commented

I was checking this and seems duplication is only happen when Group content menus are created through the UI (/group/{group_id}/menu/add) and not when are created automactically when creating the Group.

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
CreditAttribution: edysmp at MTech, LLC commented
Status: Active » Needs review
FileSize
3144201-4.patch2.07 KB

Here is a test that confirm the issue.

Status: Needs review » Needs work

The last submitted patch, 4: 3144201-4.patch, failed testing. View results

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
CreditAttribution: edysmp at MTech, LLC commented
Status: Needs work » Needs review
FileSize
3144201-6.patch4 KB

Here is a fix.
This was the problem, We were saving the group content, but Group module is doing that by default.
Deleting that, we not longer have access to the group content entity when generating a url for the group content menu entity.

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
CreditAttribution: edysmp at MTech, LLC commented
FileSize
interdiff-4-6.txt1.92 KB

Adding a interfdiff

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented 
+++ b/src/Form/GroupContentMenuForm.php
@@ -359,31 +359,19 @@ class GroupContentMenuForm extends ContentEntityForm {
+    $message_arguments = $logger_arguments;

Nit: If these are the same thing, then no need to have 2 distinct variables. Maybe just one $arguments is enough?

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
CreditAttribution: edysmp at MTech, LLC commented
FileSize
interdiff-7-9.txt1.43 KB
3144201-9.patch4.18 KB

#8: It makes sense.

  • heddn committed 626957a on 8.x-1.x authored by edysmp 
    Issue #3144201 by edysmp, Drupak, heddn: Duplicate identical entries for...
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Fixed

Thanks for all your contributions, especially the tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.