Description

The primary use case for this module is to change the inline background color of the webform through the user interface configuration.

Project link

https://www.drupal.org/project/webform_bgcolor

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/webform_bgcolor.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-webform_bgcolo...

CommentFileSizeAuthor
Webform background color.png118.77 KBVikas.Kumar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vks7056 created an issue. See original summary.

Vikas.Kumar’s picture

Vikas.Kumar CreditAttribution: Vikas.Kumar commented
Issue summary: View changes
Swetha_Bapanah’s picture

Swetha_Bapanah CreditAttribution: Swetha_Bapanah commented
Status: Needs review » Needs work

Hi @vks7056,

Please fix the below review comments.

FILE: ...site1/modules/contrib/webform_bgcolor/webform_form_bgcolor_scheme.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...l-site1/modules/contrib/webform_bgcolor/webform_form_bgcolor_scheme.module
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] There must be one blank line after the last USE statement; 2
| | found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
36 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...s/Sites/devdesktop/drupal-site1/modules/contrib/webform_bgcolor/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
35 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ..._bgcolor/src/Plugin/WebformHandler/backgroundColorSchemeWebformHandler.php
--------------------------------------------------------------------------------
FOUND 12 ERRORS AND 1 WARNING AFFECTING 12 LINES
--------------------------------------------------------------------------------
28 | ERROR | [ ] Class name must begin with a capital letter
59 | ERROR | [x] Expected 1 blank line after function; 2 found
73 | ERROR | [x] Expected 1 space before "=>"; 0 found
75 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 1
87 | ERROR | [x] Expected one space after the comma, 0 found
94 | ERROR | [x] Expected 1 space after IF keyword; 0 found
95 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
96 | ERROR | [x] Concat operator must be surrounded by a single space
96 | ERROR | [x] Concat operator must be surrounded by a single space
97 | ERROR | [x] Expected 1 space after IF keyword; 0 found
98 | ERROR | [x] Concat operator must be surrounded by a single space
102 | ERROR | [x] Expected 1 blank line after function; 0 found
103 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 208ms; Memory: 8MB

FILE: /Sites/devdesktop/drupal-site1/modules/contrib/webform_bgcolor/webform_form_bgcolor_scheme.info.yml
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-------------------------------------------------------------------------------------------------------------------------------

FILE: /Sites/devdesktop/drupal-site1/modules/contrib/webform_bgcolor/src/Plugin/WebformHandler/backgroundColorSchemeWebformHandler.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
73 | WARNING | #description values usually have to run through t() for translation
------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 65ms; Memory: 4MB

Thanks,
Swetha

kiamlaluno credited klausi.

kiamlaluno credited prajaankit.

kiamlaluno credited tikaszvince.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue tags: +PAreview: project created less than ten days ago

I am crediting the users who participated in the application closed as duplicate.

Vikas.Kumar’s picture

Vikas.Kumar CreditAttribution: Vikas.Kumar commented

Hi @all, Hi @swetha_bapanah

I fix all problems.

Thanks

Vikas.Kumar’s picture

Vikas.Kumar CreditAttribution: Vikas.Kumar commented
Status: Needs work » Needs review
shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
CreditAttribution: shaktik as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Issue summary: View changes

Thank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 at Srijan | A Material+ Company for Drupal India Association commented
Issue summary: View changes
Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 at Srijan | A Material+ Company for Drupal India Association commented

Added pareview.sh link

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs review » Fixed
Issue tags: -PAreview: project created less than ten days ago

All looking good to me after a code review.

Thanks for your contribution, Vikash!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.