Make this project compatible for drupal 9.
suggestions:

use drupal-check, rector , upgrade_status module to check the changes needed to be done
Add core_version_requirement: ^8 || ^9 to .info.yml

CommentFileSizeAuthor
#5 3145580-5.patch401 bytesDeepak Goyal
#2 3145580-2.patch399 bytesDeepak Goyal

Issue fork commerce_amazon_lpa-3145580

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Deepak Goyal created an issue. See original summary.

Deepak Goyal’s picture

Deepak Goyal CreditAttribution: Deepak Goyal at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Deepak Goyal » Unassigned
Status: Needs work » Needs review
FileSize
3145580-2.patch399 bytes

created patch for update info file please review.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Needs work 
+++ b/commerce_amazon_lpa.info.yml
@@ -1,6 +1,7 @@
 core: 8.x
+core_version_requirement: ^8 || ^9

Please use ^8.8 and remove the core property, as Commerce dropped 8.7 support.

Deepak Goyal’s picture

Deepak Goyal CreditAttribution: Deepak Goyal at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » Deepak Goyal
Deepak Goyal’s picture

Deepak Goyal CreditAttribution: Deepak Goyal at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Deepak Goyal » Unassigned
Status: Needs work » Needs review
FileSize
3145580-5.patch401 bytes

Hi @mglaman,
Made changes as you suggested please review.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Fixed

Thanks! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

noopal’s picture

noopal CreditAttribution: noopal commented

It says fixed but there is not a download for Drupal 9
Where can I download from?
Thanks

cjd4001’s picture

cjd4001 CreditAttribution: cjd4001 commented

yes I'd be interested in this for my d9 site - where can we download the module for d9?

cjd4001’s picture

cjd4001 CreditAttribution: cjd4001 commented

ok got it here: https://www.drupal.org/project/commerce_amazon_lpa/releases

berramou’s picture

berramou CreditAttribution: berramou as a volunteer commented

+1 for D9 release.

berramou opened merge request !3