I detected that the ContextReaction plugin for blocks concatenates the custom classes through blocks os a context that is rendering.

For example a context with 3 blocks:

block 1 has .green class
block 2 has .red class
block 3 has not classes

When the page is render the blocks are render

block 1 class .green class
block 2 class .green .red class
block 3 class .green .red class

This is related with the code added base on https://www.drupal.org/project/context/issues/2979536

Note: i think the issue https://www.drupal.org/project/context/issues/2979536 it could be closed

CommentFileSizeAuthor
#8 Screenshot from 2020-06-30 14-20-50.png10.35 KBpaulocs
#8 Screenshot from 2020-06-30 14-21-17.png10.44 KBpaulocs
#6 block-classes-mix-3150394-6.patch1.3 KBmaticb
#3 mix-of-block-classes-between-blocks-3150394-2.patch748 bytesMaxMendez
#2 mixed-of-all-block-classes-3150394-1.patch748 bytesMaxMendez
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MaxMendez created an issue. See original summary.

MaxMendez’s picture

MaxMendez CreditAttribution: MaxMendez commented
FileSize
mixed-of-all-block-classes-3150394-1.patch748 bytes

I found a solution so simple, here is the patch.

MaxMendez’s picture

MaxMendez CreditAttribution: MaxMendez commented
FileSize
mix-of-block-classes-between-blocks-3150394-2.patch748 bytes
caspervoogt’s picture

caspervoogt CreditAttribution: caspervoogt commented

Thanks Max; good catch. I ran into this too and immediately suspected Context, which brought me here. mix-of-block-classes-between-blocks-3150394-2.patch works for me.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Active » Reviewed & tested by the community

Patch #3 looks good to me.

maticb’s picture

maticb CreditAttribution: maticb commented
FileSize
block-classes-mix-3150394-6.patch1.3 KB

The patch is fine, but the code could be improved, array can be only a declaration, it doesn't have to be in 2 lines, also the array push makes no sense since it's only 1 item, always.

I've added the above and another slight optimization (skip array merge if it doesn't have a custom class).

maticb’s picture

maticb CreditAttribution: maticb commented
Status: Reviewed & tested by the community » Needs review
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screenshot from 2020-06-30 14-21-17.png10.44 KB
Screenshot from 2020-06-30 14-20-50.png10.35 KB

Patch #6 looks good for me.
I tested with two different blocks and they are not mixing each other.
I tested with empty classes values and they are working as well.

If you see the images, I added the class "test1" in one block and "test2" in another block.

Thanks!

  • paulocs committed d354895 on 8.x-4.x authored by maticb 
    Issue #3150394 by MaxMendez, maticb, paulocs, caspervoogt: Mix of block...
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Reviewed & tested by the community » Fixed

Fixed in dev branch!
Thanks @all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.