When enabling the module on a clean D6 site which already has plenty of book pages in the book outline {book},
such nodes will not be populated in my {outline_*} tables. Code the module so that it can cope with missing data, and add them as we go along and customize the settings of such nodes.
i.e. improve the code in nodeapi / update, to check for missing data, and do an insert instead of an update.

CommentFileSizeAuthor
#3 enable_outline_import_book.patch774 bytesbeginner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

beginner’s picture

beginner CreditAttribution: beginner commented

There are two ways to go about it:

1) either we initialize all existing book nodes to work with outline.module when the latter is initialized.

2) or we do nothing but we initialize each node separately as we go along.

solution 1 would make more sense, I think.
Next question: what needs to be initialized?

beginner’s picture

beginner CreditAttribution: beginner commented

Looking at the {outline_book} columns, I'm thinking we should update the table definition to create default values for some of them.

beginner’s picture

beginner CreditAttribution: beginner commented
Status: Active » Needs work
FileSize
enable_outline_import_book.patch774 bytes

Here is a very beginning of a patch. It's not complete, but I don't have time to play more today.

beginner’s picture

beginner CreditAttribution: beginner commented
Assigned: Unassigned » beginner
Status: Needs work » Fixed

committed full fix today.

beginner’s picture

beginner CreditAttribution: beginner commented
Status: Fixed » Active

The last patch didn't account for the following scenario:
install outline -> disable outline -> use book.module some more -> re-enable outline.

beginner’s picture

beginner CreditAttribution: beginner commented

http://api.drupal.org/api/function/hook_enable/6

beginner’s picture

beginner CreditAttribution: beginner commented
Title: Missing data from book.module, when outline is enabled later. » Data synchronization book.module when outline.module is enabled.

Done:
Import data from book.module where we don't have a corresponding outline entry:

TODO:
Update data where the vid, the place in the outline has changed, where nodes have been removed, etc...

captaindav’s picture

captaindav CreditAttribution: captaindav commented
Issue summary: View changes
Status: Active » Closed (won't fix)