Fix or ignore 33 words only used in the PostgreSQL driver

Another option is to ignore the whole file by adding the file path to "ignorePaths" of .cspell.json, The patch attached adopted this way which @alexpott did before.

Then, let's go the way #2 did. run "spellcheck:make-drupal-dict" updated the dictionary, new words from recent commits probably and setting this to RTBC.

Patch re-rolled.

As a reference: The doc of cSpell:ignore: https://github.com/streetsidesoftware/cspell/tree/master/packages/cspell...

Using cSpell:ignore is cleaner than using cSpell:enable/disable and its variations.

But it's harder to get rid of words if code were changed, and the word(s) should be removed from the ignored ones.

For maintainability, -1

Or adding above to the line closing to where words show up the first time

@longwave, @Jungle, I would say keeping few lines at the beginning of the file would be a good idea where in we can list the ignored words for that file. This will address the maintainability as well as clean code

Adding a patch as per my suggestion in #13. Seeting to NR for review.

Re #14: The patch in #14 is no difference with the patch #9 or it's a copy of the patch in #9.

@Jungle. Apologies for that. I was asking what if we add these specific words at the begininng of the file as per https://github.com/streetsidesoftware/cspell/tree/master/packages/cspell...?
I agree this would also have some maintainability issue if code were removed, but if new code is added which again uses these words, then we will have to keep repeating ignore or disable.

Thanks.

+++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
@@ -11,6 +11,11 @@
+// cSpell:ignore adbin adnum adrelid attisdropped attname attnum attrdef
+// cSpell:ignore attrelid atttypid atttypmod conkey conrelid contype

Well. This way is accepted in #3155463: Fix spelling error in Drupal\filter\Plugin\migrate\process\FilterID::getSourceFilterType(), and @alexpott commented that it's better. But needs a reroll.

@longwave, Thank you for the improvement.

+++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
@@ -6,6 +6,12 @@
+// cSpell:ignore attrelid atttypid atttypmod bigserial conkey conname conrelid

+++ b/core/misc/cspell/dictionary.txt
@@ -327,10 +315,8 @@ configurability
 conname

conname is ignored, but not being removed from the dictionary. Because it exists in core/tests/Drupal/Tests/Core/Database/Driver/pgsql/PostgresqlSchemaTest.php.

Fixing. Then 34 in total. As this is a less than 1KB change. Will back and set to RTBC once CI run finishes.

Testing is green. no CS violations. Setting to RTBC.

I have added a reroll of patch #22.

I read the IS and then skimmed the patch and was surprised to find that 'simpletests' and 'nullaction' are changed even though they are not PostgreSQL specific keywords. Since this patch is doing something different than stated in the IS the IS should be updated to state what this patch is actually doing. From my brief read it appears to be fixing all spelling errors in Core/Database/driver/pgsql and related tests.

1. +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Connection.php
   @@ -258,7 +260,7 @@ public function mapConditionOperator($operator) {
   -    // because the prefix may change, for example, like it does in simpletests.
   +    // because the prefix may change, for example, like it does in tests.
   

   simpletests in comment

   +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
   @@ -945,12 +952,12 @@ public function changeField($table, $field, $field_new, $spec, $new_keys = []) {
   -        $nullaction = 'SET NOT NULL';
   +        $null_action = 'SET NOT NULL';
   

   nullaction as a variable name.

2. This is a part of #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them. To me, the IS here is ok and its IS does not have to be as clear as other generic issues.
3. Needs reroll

Patch was rerolled.

Thanks @longwave!

1. +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Connection.php
   @@ -8,6 +8,8 @@
   +// cSpell:ignore ilike nextval
   
   +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Insert.php
   @@ -5,6 +5,8 @@
   +// cSpell:ignore nextval setval
   
   +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
   @@ -6,6 +6,12 @@
   +// cSpell:ignore adbin adnum adrelid adsrc attisdropped attname attnum attrdef
   +// cSpell:ignore attrelid atttypid atttypmod bigserial conkey conname conrelid
   ...
   +// cSpell:ignore schemaname setval
   
   @@ -566,6 +572,7 @@ public function renameTable($table, $new_name) {
   +      // cSpell:disable-next-line
   
   +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Upsert.php
   @@ -4,6 +4,8 @@
   +// cSpell:ignore nextval setval
   +
   
   +++ b/core/tests/Drupal/Tests/Core/Database/Driver/pgsql/PostgresqlSchemaTest.php
   @@ -5,6 +5,8 @@
   +// cSpell:ignore conname
   

   cspell:ignore used. Both cSpell:ignore and cspell:ignore are valid, and have usages committed. Needs a follow-up to unify them to keep consistent? Tagging "Needs followup"

2. +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Connection.php
   @@ -258,7 +260,7 @@ public function mapConditionOperator($operator) {
   -    // because the prefix may change, for example, like it does in simpletests.
   +    // because the prefix may change, for example, like it does in tests.
   

   Comment rewritting.

3. +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
   @@ -945,12 +952,12 @@ public function changeField($table, $field, $field_new, $spec, $new_keys = []) {
   -        $nullaction = 'SET NOT NULL';
   +        $null_action = 'SET NOT NULL';
   ...
          }
   

   Variable renaming

4. $ yarn spellcheck:core
   yarn run v1.22.4
   $ cspell "**/*" "../composer/**/*" "../composer.json"
   CSpell: Files checked: 14640, Issues found: 0 in 0 files
   ✨  Done in 251.54s.
   

All are good to me.

Committed c1e8435 and pushed to 9.1.x. Thanks!

Follow up made, #3305090: Should core use cspell or cSpell . Removing tag