Make settings form translatable [#3156039]

Problem/Motivation

The settings form is currently not translatable.

Proposed resolution

Add the necessary configuration to allow the settings to be translated. A patch is attached which does this, and changes the help text field to a textarea to assist in translating it through the translation form.

Data model changes

This modifies the configuration schema to set 3 fields (emails and help text) as translatable.

Release notes snippet

Make relevant settings transltable.

Comment	File	Size	Author
#5	interdiff_002_005.txt	832 bytes	askibinski
#5	tfa-translatable-settings-3156039-005.patch	1.27 KB	askibinski
#5	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.9.16 13 pass
#3	tfa-translatable-settings-3156039-002.patch	1.61 KB	dennis_meuwissen
#3	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.9 13 pass
	translatable-settings.patch	2.31 KB	dennis_meuwissen

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 July 2020 at 08:03

dennis_meuwissen created an issue. See original summary.

Comment #2

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 15 July 2020 at 20:19

Status:

Active

» Needs work

Please don't change help_text to be a textarea.

Comment #3

dennis_meuwissen CreditAttribution: dennis_meuwissen commented 16 July 2020 at 07:14

File	Size
tfa-translatable-settings-3156039-002.patch	1.61 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.9 13 pass

A new patch is attached. It also seems I forgot to add the tfa.config_translation.yml file last time around.

The help_text type is now changed into a label because leaving it as string and merely adding translatable: true does not make it show up in the translation UI. The config schema docs say type: label is shorthand for type: string, translatable: true though, but that does not seem to work.

Comment #4

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 19 November 2020 at 23:36

Status:

Needs work

» Needs review

Comment #5

askibinski CreditAttribution: askibinski as a volunteer and at iO commented 21 July 2021 at 17:58

Status:

Needs review

» Reviewed & tested by the community

File	Size
tfa-translatable-settings-3156039-005.patch	1.27 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.9.16 13 pass
interdiff_002_005.txt	832 bytes

2 files were hidden/shown/deleted

File	Size
translatable-settings.patch	2.31 KB

tfa-translatable-settings-3156039-002.patch	1.61 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.9 13 pass

Here is a minor improvement on the patch. The "translatable" property is not necessary because the core mail data type already uses "label" which is translatable by default.

Otherwise tested and works as expected.

Comment #6

16 September 2021 at 20:39

askibinski authored 2cde671 on 8.x-1.x

Issue #3156039 by dennis_meuwissen, askibinski, jcnventura: Make...

Comment #7

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 16 September 2021 at 20:40

Status:

Reviewed & tested by the community

» Fixed

Thanks for the review and patch. I don't normally accept self-added RTBCs, but in this case I'll give it a pass since you only reduced changes from the original.