drupal_lookup_path('wipe') not working properly [#315656]

When no url_alias rows is present in db upon start of request, the static $count is set to '0', and the 'wipe' does not clear this state.

Steps to reproduce:
1.) clear url_alias cache
2.) create some code that does:
a.) sets an alias using path_set_alias()
b.) get the alias back, using drupal_get_path_alias()

The alias returned will be wrong, even though path_set_alias() calls drupal_clear_path_cache() (which just calls the drupal_lookup_path('wipe')).

Cause: the $count is not reset upon wipe.

The above issue gives me problems with creation of nodes during when using an installation profile.

Comment	File	Size	Author
#7	315656-drupal-lookup-path-count-wipe.patch	524 bytes	Damien Tournoud
#7
#3	drupal-lookup-path-wipe-315656-D7.patch	525 bytes	Dave Reid
#3
#1	path.inc-drupal-5.10.patch	822 bytes	gielfeldt
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

gielfeldt CreditAttribution: gielfeldt commented 11 October 2008 at 07:53

File	Size
path.inc-drupal-5.10.patch	822 bytes

Here's a patch that fixes the problem.

Comment #2

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 11 October 2008 at 08:19

Version:

5.10

» 7.x-dev

You should just use unset($count). And this should probably be fixed in D7, then backported.

Comment #3

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 11 October 2008 at 08:25

Status:

Active

» Needs review

File	Size
drupal-lookup-path-wipe-315656-D7.patch	525 bytes

Patch for D7.

Comment #4

Anonymous (not verified) CreditAttribution: Anonymous commented 13 October 2008 at 00:22

Status:

Needs review

» Reviewed & tested by the community

Ok.

Comment #5

Damien Tournoud CreditAttribution: Damien Tournoud commented 13 October 2008 at 00:30

Status:

Reviewed & tested by the community

» Needs work

Since when can we unset static variables?

This probably doesn't work, and anyway, it should have a test.

Comment #6

Anonymous (not verified) CreditAttribution: Anonymous commented 13 October 2008 at 11:57

If a static variable is unset() inside of a function, unset() destroys the variable only in the context of the rest of a function. Following calls will restore the previous value of a variable.
function foo()
{
    static $bar;
    $bar++;
    echo "Before unset: $bar, ";
    unset($bar);
    $bar = 23;
    echo "after unset: $bar\n";
}

foo();
foo();
foo();
The above example will output:

Before unset: 1, after unset: 23
Before unset: 2, after unset: 23
Before unset: 3, after unset: 23

Which means that if the unset is at the top of the function then it works well. Setting $count to NULL instead would work for this case.