Results of scan from: https://pareview.sh/pareview/https-git.drupal.org-project-uswds.git-8.x-2.x

  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/form/form.form.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     13 | WARNING | Doc comment indicates hook_form_alter() but function
        |         | signature is "uswds_form_alter" instead of
        |         | "uswds.info_form_alter". Did you mean
        |         | hook_form_FORM_ID_alter()?
    --------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/css/style.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 33 | ERROR | [x] Multiple selectors should each be on a single line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/form/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 2 | WARNING | Line exceeds 80 characters; contains 90 characters
--------------------------------------------------------------------------


FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 1 ERROR AND 10 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 181 characters
  7 | WARNING | [ ] Line exceeds 80 characters; contains 244 characters
 11 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
 15 | WARNING | [ ] Line exceeds 80 characters; contains 249 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 298 characters
 25 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
 29 | WARNING | [ ] Line exceeds 80 characters; contains 300 characters
 31 | WARNING | [ ] Line exceeds 80 characters; contains 345 characters
 35 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
 39 | WARNING | [ ] Line exceeds 80 characters; contains 98 characters
 39 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/examples/my_subtheme/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 116 characters
 7 | WARNING | Line exceeds 80 characters; contains 113 characters
 8 | WARNING | Line exceeds 80 characters; contains 108 characters
 9 | WARNING | Line exceeds 80 characters; contains 241 characters
--------------------------------------------------------------------------
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

brian.seek created an issue. See original summary.

brian.seek’s picture

Issue summary: View changes
brian.seek’s picture

Status: Active » Needs review
FileSize
7.38 KB

This patch fixes the issues listed in the review. It's mostly max line length issues in readme files. This one looks like a false positive:

 13 | WARNING | Doc comment indicates hook_form_alter() but function
    |         | signature is "uswds_form_alter" instead of
    |         | "uswds.info_form_alter". Did you mean
    |         | hook_form_FORM_ID_alter()?
brian.seek’s picture

Assigned: brian.seek » Unassigned
Irisibk’s picture

There were some merge conflicts in the theme README between this issue and https://www.drupal.org/project/uswds/issues/3150704. @brian.seek do you mind taking a look at this patch to make sure your fixes still look good after the conflicts were resolved? Thanks!

  • brian.seek authored a02cb38 on 8.x-2.x
    Issue #3156581 by brian.seek, Irisibk: Updates for Drupal Security...
Irisibk’s picture

Status: Needs review » Fixed

This was reviewed and fixes to the patches were added. Merged to dev, thanks Brian.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.