Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
We used to need to rebuild the router a lot. Now we should not.
Proposed resolution
Remove unnecessary route rebuilds from tests.
Remaining tasks
User interface changes
N/a
API changes
N/a
Data model changes
N/a
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#5 | 3157954-5.patch | 55.26 KB | alexpott |
#2 | 3157954-2.patch | 55.26 KB | alexpott |
Comments
Comment #2
alexpottSo much unnecessary work!
Comment #3
alexpottComment #4
catchNice green patch. https://dispatcher.drupalci.org/job/drupal_patches/52719/ says 58 minute run time, compared to the 59 minutes for the last core test run (as I write this), so might be a minimal improvement for overall test run length but still good to remove all the redundant calls.
Comment #5
alexpottRecorded resolution for 'core/modules/taxonomy/tests/src/Functional/Views/TaxonomyFieldFilterTest.php'.
Comment #6
andypost+1 to remove useless rebuilds from setup, other places looks called only after setup, so this rebuild useless as well
Comment #7
catchCommitted 618f658 and pushed to 9.1.x. Thanks!
Comment #9
Wim LeersWOAH! Nice work! So much less confusion/dark magic! 👏🙏