Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Suresh Prabhu Parkala’s picture

Status: Active » Needs review
FileSize
2.22 KB

Please review!

gaurav.kapoor’s picture

Issue tags: +DIACWJuly2020
imalabya’s picture

Status: Needs review » Needs work
Issue tags: +Novice

There are more PHPCS fixes left after applying the patch

FILE: /Users/malabya/Projects/Contrib/password_field/password_field.module
-----------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------
LINE 24: ERROR [x] Expected 1 newline at end of file; 4 found (Drupal.Files.EndFileNewline.TooMany)
-----------------------------------------------------------------------------------------------------
   22:  ····default:
   23:  ··}
>> 24:  }
   25:
   26:
-----------------------------------------------------------------------------------------------------
LINE 27: ERROR [ ] More than 2 empty lines are not allowed (Drupal.WhiteSpace.EmptyLines.EmptyLines)
-----------------------------------------------------------------------------------------------------
   25:
   26:
>> 27:
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

FILE: /Users/malabya/Projects/Contrib/password_field/README.txt
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------
LINE 13: WARNING Line exceeds 80 characters; contains 82 characters (Drupal.Files.TxtFileLineLength.TooLong)
-------------------------------------------------------------------------------------------------------------
   11:  ------------
   12:
>> 13:  ·*·This·module·allows·you·to·create·fields·that·store·passwords.·It·will·store·the
   14:  ···passwords·in·encrypted·format·and·(by·default)·will·not·display·them·on·the
   15:  ···website.·So·this·module·is·really·only·useful·in·conjunction·with·other·modules
-------------------------------------------------------------------------------------------------------------
LINE 15: WARNING Line exceeds 80 characters; contains 82 characters (Drupal.Files.TxtFileLineLength.TooLong)
-------------------------------------------------------------------------------------------------------------
   13:  ·*·This·module·allows·you·to·create·fields·that·store·passwords.·It·will·store·the
   14:  ···passwords·in·encrypted·format·and·(by·default)·will·not·display·them·on·the
>> 15:  ···website.·So·this·module·is·really·only·useful·in·conjunction·with·other·modules
   16:  ···that·can·access·the·data·through·the·API·it·provides.
   17:
-------------------------------------------------------------------------------------------------------------
Time: 163ms; Memory: 4MB
nitesh624’s picture

Working on it will update in max 1 hour

gaurav.kapoor’s picture

@nitesh624 Thanks. Please assign issue to yourself by editing the issue metadata.

nitesh624’s picture

FileSize
3.36 KB
1.04 KB

Please review

nitesh624’s picture

Status: Needs work » Needs review

  • nitesh624 authored 4a9fa86 on 8.x-1.x
    Issue #3158743 by nitesh624, Suresh Prabhu Parkala: Phpcs standard fix
    
gaurav.kapoor’s picture

Status: Needs review » Fixed

Thanks for working on this. This much fixes should be enough for now, the module will require a few more changes and feature additions and then we can revisit coding standards again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.