Hi,

Coder gives a false positive in the SQL review for non-SQL strings like this:

$var = "select this and that from over there";

The attached patch should hopefully fix this, but I would like it someone else could test it out.

Cheers,
Stella

CommentFileSizeAuthor
coder_sql_false_positive.patch1.75 KBstella
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

matt2000’s picture

matt2000 CreditAttribution: matt2000 commented
Status: Needs review » Needs work

Looks good, needs reroll.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz commented

Same issue for the 7.x-2.x version: #526074: False suggestion: table names should be enclosed in {curly_brackets}

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

Coder for Drupal 6 is now frozen and only security fixes will be applied. Feel free to update this issue and reopen against 7.x-2.x or 8.x-2.x.