Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently, the Gin Toolbar successfully displays the TMGMT translation icon. However, because it is displayed as a background image, its hover and active states are out-of-sync with the expected behavior for the toolbar.
Patch to put the SVG as a `mask-image` forthcoming.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | IconsShowingNow.png | 64.04 KB | rkoller |
| #4 | noicons.png | 67.52 KB | rkoller |
| #2 | gin-3159433-tmgmt-toolbar-icon-0.patch | 613.47 KB | kmonty |
| gin_tmgmt_toolbar.png | 56.33 KB | kmonty | |
Comments
Comment #2
kmontyComment #3
saschaeggiThanks @kmonty
The icon is now included. I've used your patch but also took the time to refactor the SVG icon handling. It's now using an SVG sprite, which makes the maintenance easier and also adding new icons to Gin.
Long story short, you can checkout the latest 3.x-dev for testing.
Comment #4
rkollerI've updated to the latest 3.x-dev yesterday night... already wanted to open up a new issue today but I've figured it might be suitable for this issue as well. With the latest dev version I get an error in the devtools console:
[Error] Failed to load resource: the server responded with a status of 404 () (sprite.svg, line 0) https://d9gin.ddev.site/themes/custom/gin/dist/sprites/sprite.svg#gin-viewI've tested in Safari and Firefox on MacOS... both look that way (see screenshot noicons.png)... checked in the gin themes folder, the sprite.svg is actually there and so is the view tag with the id of
gin-viewComment #5
saschaeggiI messed up something in the webpack config. It is fixed by now :)
Comment #6
saschaeggiComment #7
rkollerthere aren't any errors loading anymore and the icons are showing again (see screenshot)
Comment #8
saschaeggiThanks!