FILE: ...s/custom/taxonomy_manager/src/Tests/TaxonomyManagerPagesTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 15 | ERROR | Missing member variable doc comment
 16 | ERROR | Missing member variable doc comment
----------------------------------------------------------------------


FILE: .../custom/taxonomy_manager/src/Tests/TaxonomyManagerConfigTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 34 | WARNING | t() calls should be avoided in classes, use
    |         | \Drupal\Core\StringTranslation\StringTranslationTrait
    |         | and $this->t() instead
 36 | WARNING | t() calls should be avoided in classes, use
    |         | \Drupal\Core\StringTranslation\StringTranslationTrait
    |         | and $this->t() instead
----------------------------------------------------------------------


FILE: ...modules/custom/taxonomy_manager/src/Form/TaxonomyManagerForm.php
----------------------------------------------------------------------
FOUND 3 ERRORS AND 9 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------
  98 | ERROR   | [x] No space found before comment text; expected "//
     |         |     &&" but found "//&&"
  98 | ERROR   | [x] Comments may not appear after statements
  99 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ($this->config('advagg_mod.settings')->get('js_adjust_sort_external'))"
     |         |     but found
     |         |     "//($this->config('advagg_mod.settings')->get('js_adjust_sort_external'))"
 102 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 114 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 176 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 201 | WARNING | [ ] Unused variable $selected_terms.
 236 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 238 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 253 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 261 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $current_path
 299 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...tml/modules/custom/taxonomy_manager/src/Form/DeleteTermsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../html/modules/custom/taxonomy_manager/src/Form/MoveTermsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...es/custom/taxonomy_manager/src/Form/AddTermsToVocabularyForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

VladimirAus created an issue. See original summary.

VladimirAus’s picture

Status: Active » Needs review
FileSize
10.55 KB
VladimirAus’s picture

FileSize
10.9 KB

Extra fixes

FILE: ...modules/custom/taxonomy_manager/src/Form/TaxonomyManagerForm.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
  92 | ERROR   | Expected type hint "EntityTypeManagerInterface";
     |         | found "EntityFormBuilderInterface" for
     |         | $entity_form_builder
 159 | WARNING | Line exceeds 80 characters; contains 83 characters
 261 | WARNING | Unused variable $selected_terms.
----------------------------------------------------------------------

  • VladimirAus committed acf51e9 on 8.x-1.x
    Issue #3160131 by VladimirAus: Fix phpcs issues
    
DamienMcKenna’s picture

Is there more to be done here or can it be marked "fixed"?

VladimirAus’s picture

Just giving a bit more time until 26th in case someone wants to test dev branch.

VladimirAus’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.