CommentFileSizeAuthor
#5 interdiff-3160317-5.txt9.31 KBjigish.addweb
#5 3160317-5.patch64.62 KBjigish.addweb
#2 3160317-2.patch64.15 KBjigish.addweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3160317-2.patch64.15 KB
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for adding the Refresh buttons. I found the following error in each resource (e.g. I just put one example such as Instance as follows; but it will apply to the other resources)

Notice: Undefined variable: updated in Drupal\aws_cloud\Service\Ec2\Ec2Service->updateInstanceEntities() (line 1103 of /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2Service.php)
#0 /var/www/html/web/core/includes/bootstrap.inc(301): _drupal_error_handler_real(8, 'Undefined varia...', '/var/www/html/w...', 1103, Array)
#1 /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2Service.php(1103): _drupal_error_handler(8, 'Undefined varia...', '/var/www/html/w...', 1103, Array)
#2 /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2Service.php(1219): Drupal\aws_cloud\Service\Ec2\Ec2Service->updateInstanceEntities(Array, false, 'aws_cloud_insta...', 'aws_ap_east_1')
#3 /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Controller/Ec2/ApiController.php(180): Drupal\aws_cloud\Service\Ec2\Ec2Service->updateAllInstances()
#4 [internal function]: Drupal\aws_cloud\Controller\Ec2\ApiController->updateAllInstanceList()

Could you please check? Also, can you consider a logic for the Drupal queue? See also the patch at: https://www.drupal.org/project/cloud/issues/3158737

jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs work » Needs review
FileSize
3160317-5.patch64.62 KB
interdiff-3160317-5.txt9.31 KB

@yas

Thank you for reviewing the patch.
I fixed error and integrated a logic in Drupal queue. Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. It looks good to me now. It looks good to me. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 41779a7 on 8.x-1.x authored by jigish.addweb 
    Issue #3160317 by jigish.addweb, yas: Add a Refresh button in All...

  • yas committed 07f1a5b on 8.x-2.x authored by jigish.addweb 
    Issue #3160317 by jigish.addweb, yas: Add a Refresh button in All...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3162125: Add a Refresh button in All listing view in each K8s resource, +#3162214: Add Refresh button in All listing view in each OpenStack resource

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.